But note that we cannot pull in an OCC dependency to FreeCAD core (it's a design decision). So, instead of using Precision::Confusion() use directly the value 1e-7.Fine, and as proposed by openBrain the standard Precision::Confusion should do it.
Refactoring Matrix.cpp/.h
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Refactoring Matrix.cpp/.h
Re: Refactoring Matrix.cpp/.h
openBrain, can you x-post this forum thread to the commit summary of the commit via git commit --amend thanks!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: Refactoring Matrix.cpp/.h
Sorry, can't give a sense to this sentence...
Would you support it up to creating the variable? I don't want to add it in a file that you will tell me it's not the good one when reviewing the PR.
Re: Refactoring Matrix.cpp/.h
I would create the file src/Base/Precision.h where we copy the most relevant functions from OCC.
Re: Refactoring Matrix.cpp/.h
git commit --amend 'Base: Uniform scaling of matrix' -m 'See discussion in https://forum.freecadweb.org/viewtopic.php?f=10&t=65959'
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: Refactoring Matrix.cpp/.h
Are you sure? Having links to forum in commit message is awful.Kunda1 wrote: ↑Fri Feb 04, 2022 7:45 pm git commit --amend 'Base: Uniform scaling of matrix' -m 'See discussion in https://forum.freecadweb.org/viewtopic.php?f=10&t=65959'
I'd happily add the link into PR description, but I'd vote against adding it in commit message.
Thx
Re: Refactoring Matrix.cpp/.h
Not married to the idea
Just that it gives some context. What do you propose?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs