PR #3788 bind expression to pad offset

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4249
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

PR #3788 bind expression to pad offset

Post by uwestoehr »

Having an expression also for the pad offset, but this works fine (with the PR applied), see this example:
OffsetTest.FCStd
(27.08 KiB) Downloaded 69 times
Last edited by uwestoehr on Sat Aug 08, 2020 11:47 am, edited 1 time in total.
openBrain
Veteran
Posts: 7988
Joined: Fri Nov 09, 2018 5:38 pm

Re: PR #3788

Post by openBrain »

As per the guidelines, this isn't needed to post here for any PR you submit, especially these like this one that don't need any discussion.
In any case, please at least add something descriptive in the title and provide a link to the PR in the OP.
chrisb
Veteran
Posts: 43422
Joined: Tue Mar 17, 2015 9:14 am

Re: PR #3788

Post by chrisb »

Can you explain this further? The pad offset was here expression aware before.

OS: macOS High Sierra (10.13)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22164 (Git)
Build type: Release
Branch: master
Hash: f2a9f712e8d68ee2393d0fe748c02096c4148a32
Python version: 3.8.5
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: C/Default (C)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
chrisb
Veteran
Posts: 43422
Joined: Tue Mar 17, 2015 9:14 am

Re: PR #3788

Post by chrisb »

I saw that openBrain responded already...
I just checked: the pad offset was already expression aware in 0.18.
openBrain wrote: Sat Aug 08, 2020 6:02 am In any case, please at least add something descriptive in the title and provide a link to the PR in the OP.
That's better than nothing, but not helpful for average users.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
openBrain
Veteran
Posts: 7988
Joined: Fri Nov 09, 2018 5:38 pm

Re: PR #3788

Post by openBrain »

chrisb wrote: Sat Aug 08, 2020 7:47 am Can you explain this further? The pad offset was here expression aware before.
This is in the property editor, but not in the task dialog at creation time. ;)
chrisb wrote: Sat Aug 08, 2020 7:54 am That's better than nothing, but not helpful for average users.
Sure. I think people interested in can browse the Github PRs directly.
User avatar
uwestoehr
Veteran
Posts: 4249
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: PR #3788

Post by uwestoehr »

openBrain wrote: Sat Aug 08, 2020 6:02 am this isn't needed to post here for any PR you submit, especially these like this one that don't need any discussion.
In any case, please at least add something descriptive in the title and provide a link to the PR in the OP.
As you see I only do report here, if I think it is necessary. In this case I wanted to give an example file, so I needed to upload it and Github did not allow me this (only as ZIP).
Sorry that I this time forgot to give the thread a clear title.
Post Reply