new arrow style

Discussions about the development of the TechDraw workbench
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

new arrow style

Postby lidiriel » Sun Dec 29, 2019 9:17 pm

Hi all,

in attachment a little patch concerning a new arrow style. It 's the first patch for integreted a new tool : GDT datum reference.
You can see arrow style in screen shot of my last build and the futur tool : gdt datum reference

Bye.
Attachments
arrow.zip
patch to the new arrow
(3.75 KiB) Downloaded 20 times
screen-shot-arrow-pyramid.png
screen-shot-arrow-pyramid.png (190.58 KiB) Viewed 415 times
User avatar
Kunda1
Posts: 8690
Joined: Thu Jan 05, 2017 9:03 pm

Re: new arrow style

Postby Kunda1 » Sun Dec 29, 2019 11:03 pm

Nice. Is there a way you can adopt a workflow that uses Github to make PRs to FreeCAD master branch ? That way devs can quickly look at your code and review it.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
wandererfan
Posts: 4078
Joined: Tue Nov 06, 2012 5:42 pm

Re: new arrow style

Postby wandererfan » Tue Dec 31, 2019 3:15 pm

lidiriel wrote:
Sun Dec 29, 2019 9:17 pm
in attachment a little patch concerning a new arrow style. It 's the first patch for integreted a new tool : GDT datum reference.
You can see arrow style in screen shot of my last build and the futur tool : gdt datum reference
merged - git commit ac680bf9b7 git commit 3c97d0b9e8 git commit 6d158ac1b8
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

Re: new arrow style

Postby lidiriel » Tue Dec 31, 2019 3:48 pm

Kunda1 wrote:
Sun Dec 29, 2019 11:03 pm
Nice. Is there a way you can adopt a workflow that uses Github to make PRs to FreeCAD master branch ? That way devs can quickly look at your code and review it.
Ok i will read the github wiki page to prepre my next patch. Now i work on a local branch (specific for the gdt first tool) of a local clone of master.


see you next year.

bye.