Sketcher : Chamfer, Arc Slot, Rectangle Slot, Frame

[paddle]

Hey guys,
I implemented Chamfer, Arc Slot, Rectangle Slot on top of my constrain Contextually branch, this way they now support ToolSettings.
Also introduced a small Frame tool that has been asked to me.

phpBB [video]

[openBrain]

Looks like it needs some polishing (inward fillet creates partially redundant constraints, which isn't acceptable).

Wonder how you will make all this reviewable and mergeable.
Remember we expect :
* Clean commit history, with atomic commits as much as possible
* New features are made an option in possible extent, except if you obtained a strong acknowledgement of community about the changes
* Automatic tests to come with new features

[paddle]

Looks like it needs some polishing (inward fillet creates partially redundant constraints, which isn't acceptable).

Regarding inward fillet partial reundand constraints it's happening when you try to connect 2 arcs of circles together by applying coincidence to the 3 points :
- Create one arc
- Create another arc
- Coincidence between one arc end and the other arc end
- Coincidence between one arc second end and the other arc second end
- Coincidence between the 2 mids points

inn.png (36.73 KiB) Viewed 1824 times

That gives you the redundant. Which doesn't make sens, it's not redundant. So it's a solver's innacuracy.

[openBrain]

That gives you the redundant. Which doesn't make sens, it's not redundant. So it's a solver's innacuracy.

It's totally wrong. An arc of circle is 5 DoF. 3x coincident = 3x2 = 6 DoF removed. You got a redundancy.

[paddle]

It's totally wrong. An arc of circle is 5 DoF. 3x coincident = 3x2 = 6 DoF removed. You got a redundancy.

Then how do you make this result without 3x coincident?

[openBrain]

Then how do you make this result without 3x coincident?

2x coincident on endpoints, and a vertical (or horizontal) on center.
Just an example, whatever is fine for you but doesn't overconstrain.

[paddle]

Then how do you make this result without 3x coincident?

2x coincident on endpoints, and a vertical (or horizontal) on center.
Just an example, whatever is fine for you but doesn't overconstrain.

Thanks. That doesn't feel very intuitive to have to apply a vertical on centers but it works. Besides it seemed to solve the bugs I had in the video with polychamfers inward too.

[madslethdanielsen]

Hallo nice work..
I have used freecad since 2008...
1 features iam mising in the Sketcher is....

2d ofset i no it is in part WB

the funktions was in SOLIDWORKS

Br Mads

[openBrain]

That doesn't feel very intuitive to have to apply a vertical on centers but it works.

There are dozen of constraint combination that works.
The advantage of this one is that it cannot flip.

[paddle]

Wonder how you will make all this reviewable and mergeable.
Remember we expect :
* Clean commit history, with atomic commits as much as possible
* New features are made an option in possible extent, except if you obtained a strong acknowledgement of community about the changes
* Automatic tests to come with new features

Arc Slot, Rectangle Slot, frame are just reimplementation of DrawSketchHandler, they are easy to review.
Constrain Contextually and tool settings need more thought on the review. I hope we'll sort it out with Abdullah !