Addon Manager Redesign 2021

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
adrianinsaval
Veteran
Posts: 3156
Joined: Thu Apr 05, 2018 5:15 pm

Re: Addon Manager Redesign 2021

Post by adrianinsaval »

can't you trick it into believing there are updates necessary by checking out an older commit of the repo?
User avatar
chennes
Veteran
Posts: 2240
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

No, then you're in detached head, git knows you did it deliberately.
Chris Hennes
Pioneer Library System
User avatar
Kunda1
Veteran
Posts: 12709
Joined: Thu Jan 05, 2017 9:03 pm

Re: Addon Manager Redesign 2021

Post by Kunda1 »

When trying to install GDML workbench i see this in the Report view:

Code: Select all

11:00:30  b'pip 22.0.4 from /snap/freecad-ppd/223/lib/python3.8/site-packages/pip (python 3.8)\n'Nonepip 22.0.4 from /snap/freecad-ppd/223/lib/python3.8/site-packages/pip (python 3.8)
looks like there's a missing double quote somewhere
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Veteran
Posts: 12709
Joined: Thu Jan 05, 2017 9:03 pm

Re: Addon Manager Redesign 2021

Post by Kunda1 »

In addition to the above, I noticed an UX issue with the Addon Manager when installing 3rd party deps the dialog directs the user to browse the Report view console but that is out of focus when we're in the Addon Manager. Is there a way to clone/mirror the report view to the bottom of the Addon Manager window for the duration of the Addon Manager being active and in focus? Upon exiting the Addon Manager the Report view is 'returned'? This way we can watch the activity of the addon manager, copy/paste text from the report view (without having to exit Addon Manager to do so)
Unable to access report view unless exiting Addon Manager
Unable to access report view unless exiting Addon Manager
Screenshot_20220407_113039.png (139.32 KiB) Viewed 925 times
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
chennes
Veteran
Posts: 2240
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

Kunda1 wrote: Thu Apr 07, 2022 3:09 pm looks like there's a missing double quote somewhere
That's an artifact of the way pip echos its output, I don't think I have any control over that.
Chris Hennes
Pioneer Library System
User avatar
Kunda1
Veteran
Posts: 12709
Joined: Thu Jan 05, 2017 9:03 pm

Re: Addon Manager Redesign 2021

Post by Kunda1 »

chennes wrote: Thu Apr 07, 2022 4:27 pm That's an artifact of the way pip echos its output, I don't think I have any control over that.
Fascinating, so you can you recreate that in pip directly?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
uwestoehr
Veteran
Posts: 4284
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: Addon Manager Redesign 2021

Post by uwestoehr »

While performing to update my addons using recent master I got this error:

Code: Select all

14:44:21  Syntax error while reading __files__ from macro AeroFoil
14:44:21  __Files__         = "AeroFoil_UI_Files/AeroFoil_Initial_Dialog.ui, AeroFoil_UI_Files/AeroFoil_NACA4Digit_Dialog.ui, \
User avatar
chennes
Veteran
Posts: 2240
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

It looks like the problem is in the script that's on the Wiki -- the one in GitHub is fine. https://wiki.freecadweb.org/index.php?t ... o_AeroFoil uses the Python line continuation character in its list of __Files__, which is not allowed. Those metadata lines are not actually executed by the Addon Manager, they are just hand-parsed. I modified that code a little bit in this redesign to allow for certain common idioms, but actually moving to executing the Python I think is beyond the scope of something the Addon Manager should do.
Chris Hennes
Pioneer Library System
User avatar
uwestoehr
Veteran
Posts: 4284
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: Addon Manager Redesign 2021

Post by uwestoehr »

chennes wrote: Fri Apr 08, 2022 2:28 pm is beyond the scope of something the Addon Manager should do.
I thought the AddonManager is working fine, just that something in AeroFoil needs to be fixed.
I only reported it here since some macro/WB managers reading this thread and will be informed.
TheMarkster
Veteran
Posts: 4514
Joined: Thu Apr 05, 2018 1:53 am

Re: Addon Manager Redesign 2021

Post by TheMarkster »

In the update report can the new versions be displayed? Is it possible an update can be applied from cache and not be the very latest?
Post Reply