Sketcher Constraint widget rework
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
Sketcher Constraint widget rework
Following that discussion : https://forum.freecadweb.org/viewtopic.php?f=34&t=71595
Let me know if you spot any problem/feature regression with new UI. But I think it can do all it did and more.
Please test !
I made that while on my paddle_widget_testing branch. (because I can't compile master right now). You can compile my branch : https://github.com/PaddleStroke/FreeCAD ... et_testing
or cherry pick these commit :
https://github.com/PaddleStroke/FreeCAD ... c518ede5b7
https://github.com/PaddleStroke/FreeCAD ... b5ee1c08e1
Edit: Button to show filter has been replaced by checkbox
Let me know if you spot any problem/feature regression with new UI. But I think it can do all it did and more.
Please test !
I made that while on my paddle_widget_testing branch. (because I can't compile master right now). You can compile my branch : https://github.com/PaddleStroke/FreeCAD ... et_testing
or cherry pick these commit :
https://github.com/PaddleStroke/FreeCAD ... c518ede5b7
https://github.com/PaddleStroke/FreeCAD ... b5ee1c08e1
Edit: Button to show filter has been replaced by checkbox
Last edited by paddle on Fri Sep 30, 2022 12:50 pm, edited 1 time in total.
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
Re: Sketcher Constraint widget rework
I had a plan to rework that too, but no time till now.
I think this is still suboptimal (personal opinion).
What I'd like is that the hide/show filter is actually a combo box.
* When it's unchecked, filter is disabled. No filter applies but your filter choices are kept in the background. At this time, you can hide much filter controls.
* When it's checked, filter is enabled. It applies back same settings as last time it was disabled (at least over a session, but ideally it is saved in user preferences and reused between different sessions). Filter controls are fully accessible to user at this time.
I think this is still suboptimal (personal opinion).
What I'd like is that the hide/show filter is actually a combo box.
* When it's unchecked, filter is disabled. No filter applies but your filter choices are kept in the background. At this time, you can hide much filter controls.
* When it's checked, filter is enabled. It applies back same settings as last time it was disabled (at least over a session, but ideally it is saved in user preferences and reused between different sessions). Filter controls are fully accessible to user at this time.
Re: Sketcher Constraint widget rework
Yes it's not perfect.openBrain wrote: ↑Fri Sep 30, 2022 11:08 am I had a plan to rework that too, but no time till now.
I think this is still suboptimal (personal opinion).
What I'd like is that the hide/show filter is actually a combo box.
* When it's unchecked, filter is disabled. No filter applies but your filter choices are kept in the background. At this time, you can hide much filter controls.
* When it's checked, filter is enabled. It applies back same settings as last time it was disabled (at least over a session, but ideally it is saved in user preferences and reused between different sessions). Filter controls are fully accessible to user at this time.
You mean a checkbox rather than combobox right? Yes you'r right it's better than a button. I don't know why I used a button actually, checkbox makes more sens.
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
Re: Sketcher Constraint widget rework
Yes, checkbox rather then button.
Also, in your implementation, is filter disabled when hidden?
BTW, is this topic well suited in 'Announcement'? Maybe 'open discussion' would be more community inclusive right?
Also, in your implementation, is filter disabled when hidden?
BTW, is this topic well suited in 'Announcement'? Maybe 'open discussion' would be more community inclusive right?
Re: Sketcher Constraint widget rework
No it wasn't disabled when hidden. But with a checkbox it makes more sens to disable filter when hidden.
I posted in announcement because it was already openly discussed for some time (https://forum.freecadweb.org/viewtopic.php?f=34&t=71595) and it seemed that it reached a consensus.
I just finished replacing button by checkbox and pushed a second commit. So to test you need to grab 2 commits now to test with checkbox.
Second commit :
https://github.com/PaddleStroke/FreeCAD ... b5ee1c08e1
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
- adrianinsaval
- Veteran
- Posts: 5553
- Joined: Thu Apr 05, 2018 5:15 pm
Re: Sketcher Constraint widget rework
For the filters, how about a tool button that launches a borderless widget with the checkboxes? Like a fake combobox with checkboxes.
Re: Sketcher Constraint widget rework
That's what I had in mind initially, but seemed difficult to implement.adrianinsaval wrote: ↑Fri Sep 30, 2022 1:03 pm For the filters, how about a tool button that launches a borderless widget with the checkboxes? Like a fake combobox with checkboxes.
But now the checkbox is better I think, because you can inactivate the filter without resetting the values. So user can keep his settings and toggle on/off his filter.
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
Re: Sketcher Constraint widget rework
I like that the constraint types are now nested. Make things clearer.paddle wrote: ↑Fri Sep 30, 2022 10:41 am Following that discussion : https://forum.freecadweb.org/viewtopic.php?f=34&t=71595
Re: Sketcher Constraint widget rework
I move this to Open discussion forum. It could be seen as a very detailed feature proposal .
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: Sketcher Constraint widget rework
Very nice work!
Although the filters are now much smaller than the rest, they are still the widest section. If they are not needed, 3D view could be enlarged a bit, but that hides the expansion handles for "Edit controls", "Constraints", "Elements", ...
Is it possible to make these smaller, so that they are still available, even when the panel is smaller than the Filter?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.