Some remarks aren't took into account.obelisk79 wrote: ↑Fri Jan 13, 2023 1:31 pm This effort, and the corresponding PR's seems to have gone stale. Are the any pending concerns that are still outstanding? I haven't seen any either in this thread or on github.
According to the documents adopted regarding contribution of PR's:
12. Maintainers SHALL merge valid PRs from other Contributors rapidly.
13. Maintainers MAY, at their discretion merge PRs that have not met all criteria to be considered valid to:
1. end fruitless discussions
Have we reached the 'fruitless discussion phase' regarding this? Additionally, it would seem that if merging such a PR into the master dev branch proves to be dysfunctional or largely unpopular, it could be reverted afterwards. Yes? No?
Commits aren't squashed.
It needs another review after everything in cleaned up.
Contribution process is a whole (and after all maybe only guidelines) that you have to take as such. You can't just excerpt 2 lines and present them as valid by themselves.
To be clear, I have discussed with @abdullah and we decided that we will be pretty finicky on the code that goes to Sketcher given its core importance to FC.