Shapestring Transform tool changed in 0.21
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
Shapestring Transform tool changed in 0.21
Video proof that the transform tool worked in 0.20:
And it doesn't in 0.21:
And it doesn't in 0.21:
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Re: Shapestring Transform tool changed in 0.21
Using just Windows Conda builds (so the Qt, Python versions are as near as I can get) I find the change happened before the 0.20 release Git version 29177:
The last build I have that works as expected is (approx 1st March 2022):
and the first build I have that fails is (approx 8th June 2022) :
I'll look at these initially https://github.com/FreeCAD/FreeCAD/comm ... ragger.cpp otherwise it may take a significant length of time to Git Bisect to get the root cause.
The last build I have that works as expected is (approx 1st March 2022):
Code: Select all
OS: Windows 7 SP 1 (6.1)
Word size of FreeCAD: 64-bit
Version: 0.20.27809 (Git)
Build type: Release
Python 3.8.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: English/United Kingdom (en_GB)
Installed mods:
* A2plus 0.4.56
* AirPlaneDesign 0.4.0
* Assembly3 0.11.3
* Assembly4 0.11.12
* CfdOF 1.17.0
* CurvedShapes 1.0.3
* Curves 0.4.4
* dodo
* fasteners 0.3.41
* fcgear 1.0.0
* FeedsAndSpeeds 0.4.0
* Help 1.0.0-alpha
* Manipulator 1.4.3
* Plot 2022.4.17
* sheetmetal 0.2.49
* Silk -851823088.0.0
and the first build I have that fails is (approx 8th June 2022) :
Code: Select all
OS: Windows 7 SP 1 (6.1)
Word size of FreeCAD: 64-bit
Version: 0.20.29045 (Git)
Build type: Release
Branch: master
Hash: af811b34b3
Python 3.8.13, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: English/United Kingdom (en_GB)
Installed mods:
* A2plus 0.4.56
* AirPlaneDesign 0.4.0
* Assembly3 0.11.3
* Assembly4 0.11.12
* CfdOF 1.17.0
* CurvedShapes 1.0.3
* Curves 0.4.4
* dodo
* fasteners 0.3.41
* fcgear 1.0.0
* FeedsAndSpeeds 0.4.0
* Help 1.0.0-alpha
* Manipulator 1.4.3
* Plot 2022.4.17
* sheetmetal 0.2.49
* Silk -828230128.0.0
Re: Shapestring Transform tool changed in 0.21
I have a version from 26/4/22 doesn't work here:-
HTH Steve.
Code: Select all
OS: Manjaro Linux (XFCE/xfce)
Word size of FreeCAD: 64-bit
Version: 0.20.28751 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 660655e)
Hash: 660655e54c97b5017ff0ac1e030059308cd4e3f5
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: English/United Kingdom (en_GB)
Installed mods:
* Curves 0.5.0
* fasteners 0.3.46
* fcgear 1.0.0
* CurvedShapes 1.0.3
* kicadStepUpMod 10.13.3
Re: Shapestring Transform tool changed in 0.21
This is caused by this commit:
https://github.com/FreeCAD/FreeCAD/comm ... 22646dc1ff
The setEdit function should return None if mode is 1:
https://github.com/FreeCAD/FreeCAD/blob ... py#L41-L48
I'll do a PR.
https://github.com/FreeCAD/FreeCAD/comm ... 22646dc1ff
The setEdit function should return None if mode is 1:
https://github.com/FreeCAD/FreeCAD/blob ... py#L41-L48
I'll do a PR.
Re: Shapestring Transform tool changed in 0.21
Did some testing and this is what I came up with https://github.com/FreeCAD/FreeCAD/comp ... D:patch-46
Tested using the 0.20 Release build.
Tested using the 0.20 Release build.
Code: Select all
OS: Windows 7 Version 6.1 (Build 7601: SP 1)
Word size of FreeCAD: 64-bit
Version: 0.20.29177 (Git)
Build type: Release
Branch: releases/FreeCAD-0-20
Hash: 68e337670e227889217652ddac593c93b5e8dc94
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.2
Locale: English/United Kingdom (en_GB)
Installed mods:
* A2plus 0.4.56
* AirPlaneDesign 0.4.0
* Assembly3 0.11.3
* Assembly4 0.11.12
* CfdOF 1.17.0
* CurvedShapes 1.0.3
* Curves 0.4.4
* dodo
* fasteners 0.3.41
* fcgear 1.0.0
* FeedsAndSpeeds 0.4.0
* Help 1.0.0-alpha
* Manipulator 1.4.3
* Plot 2022.4.17
* sheetmetal 0.2.49
* Silk
Re: Shapestring Transform tool changed in 0.21
Hmm...I see the comment and commit: What does it mean it doesn't belong to any branch in this repository?Roy_043 wrote: ↑Wed Jul 06, 2022 5:03 pm My comment:
https://github.com/FreeCAD/FreeCAD/comm ... 71676aba23
And, if I do a git pull on master, I get "Already up to date"...And my local was up to date 6 hours ago.
Sometimes (well much of the time) git baffles me.
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Re: Shapestring Transform tool changed in 0.21
No probs, I'll leave it in your capable hands.Roy_043 wrote: ↑Wed Jul 06, 2022 5:03 pm My comment:
https://github.com/FreeCAD/FreeCAD/comm ... 71676aba23