Sketch_MakeInternals and toponaming

Report observations made with the new Toponaming branch.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Sketch_MakeInternals and toponaming

Post by -alex- »

realthunder wrote:ping
Hi realthunder, thanks a lot for Sketch MakeInternals feature! This is a great feature, very promising in order to group many features in few master sketches then Pad and pocket quickly :D

Image

However it seems there is a topological issue despite your algorithm. Is it a bug?

Linkstage3_sketch_Internal-TNP.gif
Linkstage3_sketch_Internal-TNP.gif (560.79 KiB) Viewed 1478 times
Linkstage3-Sketch_MakeInternals-TNP.FCStd
(14.1 KiB) Downloaded 38 times

Code: Select all

OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.31507 (Git)
Build type: Unknown
Branch: LinkDaily
Hash: d697dc28623fab496c3175986a04acac94082119
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)

Thank you for your great work and your kind attention.
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Sketch_MakeInternals and toponaming

Post by realthunder »

I have just pushed a few commits to fix this problem. Please sync the try.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sketch_MakeInternals and toponaming

Post by -alex- »

realthunder wrote: Thu Oct 27, 2022 1:53 pm I have just pushed a few commits to fix this problem. Please sync the try.
Done:

Code: Select all

OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.31516 (Git)
Build type: Unknown
Branch: LinkDaily
Hash: 2b6bb77ed6671ccb15a583a3e068798aae67d1fa
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)

Tanks for the quick fix, so much appreciated!

The behaviour seems better, but still weird though. The sequence of operations does matter it seems.
See below with the bloc.fcstd file:



1- Stable topology (=TNP OK):
Linkstage3_sketch_Internal-TNP-sequence-OK.gif
Linkstage3_sketch_Internal-TNP-sequence-OK.gif (360.31 KiB) Viewed 1335 times

2- Non stable topology (=TNP OK):

Sorry for the noise, it was necessary to sketch and pad again from scratch in files, then the topology is stable with any changes.
For reasonable changes of shape I'm not able to break the topology now :D
FC-Link_sketch-internal_Bloc-TNP-OK.FCStd
(33.12 KiB) Downloaded 30 times
Linkstage3-Sketch_MakeInternals-TNP-OK.FCStd
(13.99 KiB) Downloaded 29 times
Linkstage3_sketch_Internal-TNP-OK.gif
Linkstage3_sketch_Internal-TNP-OK.gif (658.04 KiB) Viewed 1304 times

Thanks again for this great feature!
Last edited by -alex- on Thu Oct 27, 2022 10:40 pm, edited 2 times in total.
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Sketch_MakeInternals and toponaming

Post by realthunder »

To minimize uncertainty, please recreate the Pad/Pocket, because there is a bug that I just fixed that may cause the reference to sketch internal geometry got lost in tracking of its name change.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sketch_MakeInternals and toponaming

Post by -alex- »

realthunder wrote: Thu Oct 27, 2022 10:16 pm To minimize uncertainty, please recreate the Pad/Pocket
Cross post.
You read in my mind, you're too fast ;)
I'm gonna replace the bloc.fcstd file above by the new stable one to avoid misunderstandings.
Your previous fix is already very good.
User avatar
-alex-
Veteran
Posts: 1856
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Sketch_MakeInternals and toponaming

Post by -alex- »

realthunder wrote:ping
Sketch_MakeInternals is great, unfortunately we cannot use it in Part WB workflow.
Would you plan to expose MakeInternals subelements to the property "Base" of Part_Extrude feature in your branch?
That would be great :)
Post Reply