When can we expect to see TNP PR's?

Report observations made with the new Toponaming branch.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
obelisk79
Veteran
Posts: 1056
Joined: Thu Sep 24, 2020 9:01 pm

When can we expect to see TNP PR's?

Post by obelisk79 »

I see a lot of great activity in both linkstage and main github repos over the last few weeks.

While it might be a bit presumptuous on my part, I believe that TNP mitigation is probably one of the most anticipated features for this development cycle. I'm curious when we could reasonably expect to start seeing some PR's being made by @realthunder to the development branch?
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: When can we expect to see TNP PR's?

Post by realthunder »

There are huge code changes in upstream since my last topo naming PR. It'll take a while for me to merge those changes. And once ready, it will be pushed into a separate TopoNaming branch in the upstream for the public to test. I expect the first batch to be ready in a few weeks. But, it'll take a much longer time for all the bits and pieces to be in place before the end user can get the full benefit of the new topo naming.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: When can we expect to see TNP PR's?

Post by Kunda1 »

@realthunder is there any orientation you can provide in regards to what upstream could do to lessen the amount of work you have to do? For example, is there any part of the source code you recommend to avoid modifying (as best as possible) while TNP development/merge is ongoing ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
obelisk79
Veteran
Posts: 1056
Joined: Thu Sep 24, 2020 9:01 pm

Re: When can we expect to see TNP PR's?

Post by obelisk79 »

Realthunder thanks for the candid response, and your work. I know this feature is quite anticipated and those of us who try to provide support and guidance both here on the forums and in chat spend a lot of time teaching people about TNP and how to avoid it.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: When can we expect to see TNP PR's?

Post by Kunda1 »

obelisk79 wrote: Thu Jul 07, 2022 6:02 pm spend a lot of time teaching people about TNP and how to avoid it.
This goes without saying.
Realthunder was and is one of those people as well.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
obelisk79
Veteran
Posts: 1056
Joined: Thu Sep 24, 2020 9:01 pm

Re: When can we expect to see TNP PR's?

Post by obelisk79 »

Of course! :D
user1234
Veteran
Posts: 3301
Joined: Mon Jul 11, 2016 5:08 pm

Re: When can we expect to see TNP PR's?

Post by user1234 »

@realthunder: also thanks for feedback and work!

Greetings
user1234
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: When can we expect to see TNP PR's?

Post by Kunda1 »

realthunder posted to the his patreon recently.
Context: in regards to 'Release' he's referring to Link branch.
ref: https://www.patreon.com/posts/2022-07-04-68640979
ref: https://www.patreon.com/posts/2022-07-04-68640979
RT-Patreon-Toponaming.png (139.26 KiB) Viewed 1375 times
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply