[fixed] conda windows builds fail again

This subforum is specifically to discuss packaging issues on different platforms (windows, mac, linux), and using different packaging systems (conda, etc...)
Post Reply
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

[fixed] conda windows builds fail again

Post by looo »

Code: Select all

%SRC_DIR%\src\Gui\Document.cpp(1858): error C2672: 'std::isspace': no matching overloaded function found
%SRC_DIR%\src\Gui\Document.cpp(1858): error C2780: 'bool std::isspace(_Elem,const std::locale &)': expects 2 arguments - 1 provided
maybe releated:
https://github.com/microsoft/vcpkg/issues/14027
Last edited by looo on Mon Feb 28, 2022 4:42 pm, edited 1 time in total.
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: [conda] windows builds fail again

Post by Syres »

In git commit 8a376e5

Code: Select all

#include <cctype>
appears to have been removed from src\Gui\Document.cpp, have you tested putting this back in temporarily at least for a test? I used https://en.cppreference.com/w/cpp/string/byte/isspace for reference.
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: [conda] windows builds fail again

Post by looo »

Syres wrote: Sun Feb 27, 2022 9:28 am In git commit 8a376e5

Code: Select all

#include <cctype>
appears to have been removed from src\Gui\Document.cpp, have you tested putting this back in temporarily at least for a test? I used https://en.cppreference.com/w/cpp/string/byte/isspace for reference.
tested and didn't solve the issue.
https://github.com/looooo/freecad-feeds ... 3d217cd629
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: [conda] windows builds fail again

Post by Syres »

looo wrote: Mon Feb 28, 2022 9:07 am tested and didn't solve the issue.
https://github.com/looooo/freecad-feeds ... 3d217cd629
That change appears to be applied to src\Gui\Application.cpp but I did state src\Gui\Document.cpp or am I reading your patch incorrectly?
wmayer
Founder
Posts: 20319
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [conda] windows builds fail again

Post by wmayer »

User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: [conda] windows builds fail again

Post by looo »

Syres wrote: Mon Feb 28, 2022 11:11 am
looo wrote: Mon Feb 28, 2022 9:07 am tested and didn't solve the issue.
https://github.com/looooo/freecad-feeds ... 3d217cd629
That change appears to be applied to src\Gui\Application.cpp but I did state src\Gui\Document.cpp or am I reading your patch incorrectly?
sorry, my fault
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: [conda] windows builds fail again

Post by looo »

wmayer wrote: Mon Feb 28, 2022 11:37 am git commit 063077ce84
thanks, this fixes the issue
Post Reply