FreeCAD Forum

NewJoker wrote: ↑Fri Feb 25, 2022 6:09 pm Hi,

I have the CfdOF workbench installed on one PC but now I'd like to have it on another machine as well and I've encountered a strange issue with installation. When I choose this workbench in the Addon Manager and press Install/update selected, the following message appears:

Code: Select all

Some errors were found that prevent to install this workbench: Some errors were found that prevent to install this workbench. Please install the missing components first.

oliveroxtoby wrote: ↑Fri Feb 25, 2022 7:42 pm I'm not sure what's happening here, but have you tried installing the Plot workbench first?

NewJoker wrote: ↑Sat Feb 26, 2022 10:59 am

oliveroxtoby wrote: ↑Fri Feb 25, 2022 7:42 pm I'm not sure what's happening here, but have you tried installing the Plot workbench first?

Thanks, it worked when I installed the Plot workbench first. Maybe the error message I was getting before ("Please install the missing components first") could be expanded a bit to indicate specifically that the Plot workbench needs to be installed.

oliveroxtoby wrote: ↑Sat Feb 26, 2022 8:06 pm ... The addon manager has been completely refactored for 0.20 (by @chennes) so I'm fairly sure this won't be a problem in future.

herbk wrote: ↑Sun Feb 27, 2022 9:16 am Hi Oliver,

oliveroxtoby wrote: ↑Sat Feb 26, 2022 8:06 pm ... The addon manager has been completely refactored for 0.20 (by @chennes) so I'm fairly sure this won't be a problem in future.

Dos the addon manager know the dependecy of each WB? I don't think so... ;) ;)

oliveroxtoby wrote: ↑Sun Feb 27, 2022 4:31 pm Workbenches can declare their dependencies in their metadata.txt or package.xml files.

try:
    import Plot
catch ImportError:
    FreeCAD.Console.PrintError(translate("CfdOF","Failed to import Plot module. Exiting CfdOF.")
    return

chennes wrote: ↑Mon Feb 28, 2022 3:33 am

oliveroxtoby wrote: ↑Sun Feb 27, 2022 4:31 pm Workbenches can declare their dependencies in their metadata.txt or package.xml files.

I'm glad you mentioned that here -- it prompted me to try to install this WB, and I discovered I couldn't because it declares a dependency on the Plot Workbench. This took my down a whole big rabbit hole, but the upshot is that as of 17 Aug 2021 in git commit b7d06844c, Plot is no longer a Workbench, it is just a Module (that is, it has no InitGui.py file, and no main class derived from Workbench). Which currently means that you can't declare a dependency on it, because that code can only look for workbenches!

There are a two paths forward, both of which involve changing that dependency line. First, you can handle it entirely within CfdOF -- remove the dependency line entirely, and just do something like:

Code: Select all

try:
    import Plot
catch ImportError:
    FreeCAD.Console.PrintError(translate("CfdOF","Failed to import Plot module. Exiting CfdOF.")
    return

Second, you can modify the dependency to say "Plot" instead of "Plot Workbench", and I can write the above code in the Addon Manager, refusing to even install CfdOF if you don't have Plot.

Do you have a preference between the two?