TechDraw Multithread Testing

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Multithread Testing

Post by adrianinsaval »

user1234 wrote: Wed Aug 17, 2022 7:39 pm That is fine, but the problem is, will people do download this?
IMO yes, at least for popular features like this or paddle's sketcher stuff or specially TN, of course not as many as with the dev releases but even one is better than no testing.
user1234
Veteran
Posts: 3337
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

@Kunda1, @adrianinsaval: yes, convinced, thanks.

btw: this feature is merged from @wandererfan, thank you very much!


@Kunda1: two things, since you are very good in managing or maybe even you created this or at least you know, who is managing this:

- in the PRs are a link to the 0.20 changelog, i think this should be updated to a new thread to 0.21. I did not find one (too common search terms, maybe there is no one). This feature should be added, since it is a gamechanger for people which make TechDraw drawings.

- the wiki https://wiki.freecadweb.org/Release_notes_0.21 is empty. I do not know who created this, this feature should be added too.


@wandererfan: i found a minor issue: which was not before, when trying to close before the recalcultaing is finnished, i get a message

terminal:

Code: Select all

������������������嘓������嘓������������1 is waiting for face finding to finish
log:

Code: Select all

Msg: \FD\AA\9B\B7\89\90\FD\AD\99\97\91\89\FC\A5\85\BA\B0\80嘓\FC\AB\B8\83\BB\80嘓\FC\BD\8E\A7\A0\99\FC\91\95\90\B3\A01 is waiting for face finding to finish
Could it be, that in the line

https://github.com/FreeCAD/FreeCAD/blob ... t.cpp#L164

%S must be replaced with %s?


Greetings
user1234
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

user1234 wrote: Thu Aug 18, 2022 2:55 pm @wandererfan: i found a minor issue: which was not before, when trying to close before the recalcultaing is finnished, i get a message
At times like these, I regret only being able to swear in two languages. :oops:

The check for running threads at close time was added to hlrThreadrc2 to prevent a segfault. I'll fix the typo directly. Thanks for reporting.
user1234
Veteran
Posts: 3337
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

wandererfan wrote: Thu Aug 18, 2022 3:03 pm I regret only being able to swear in two languages.
C and C++? (this is just a joke).

wandererfan wrote: Thu Aug 18, 2022 3:03 pm The check for running threads at close time was added to hlrThreadrc2 to prevent a segfault. I'll fix the typo directly.
I can make it and the good thing is, while searching this issue, i learned something.


Greetings
user1234
user1234
Veteran
Posts: 3337
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

Besides that, if someone does not work, someone can not make errors. Also we say here, when some does planing, there are chips. That is a fact that may new users (here, not in gerneral) forget.

Greetings
user1234
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

user1234 wrote: Thu Aug 18, 2022 2:55 pmtwo things
This is probably due to the plan that the next version will be v1.0 Release_notes_1.0. Thanks for the heads up.
CC @uwestoehr, should we update the PR template to link to 1.0 Release notes?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Multithread Testing

Post by adrianinsaval »

user1234 wrote: Thu Aug 18, 2022 3:07 pm
wandererfan wrote: Thu Aug 18, 2022 3:03 pm I regret only being able to swear in two languages.
C and C++? (this is just a joke).
:lol: :lol: :lol: :lol:
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

user1234 wrote: Thu Aug 18, 2022 2:55 pm i found a minor issue: which was not before, when trying to close before the recalcultaing is finnished, i get a message
terminal:

Code: Select all

������������������嘓������嘓������������1 is waiting for face finding to finish
Should be fixed by git commit d6806167e1.
user1234
Veteran
Posts: 3337
Joined: Mon Jul 11, 2016 5:08 pm

Re: Multithread Testing

Post by user1234 »

wandererfan wrote: Thu Aug 18, 2022 6:48 pm Should be fixed by git commit d6806167e1.
Already seen, compiled and tested, yes it works now. Thanks!

Greetings
user1234
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

user1234 wrote: Thu Aug 18, 2022 3:07 pm C and C++?
:lol: not the two I was thinking of, but thanks for the giggle.
Post Reply