[FIXED} Image scaling broken in freecad v0.20

Discussions about the development of the TechDraw workbench
Post Reply
computer extreme
Posts: 2
Joined: Mon Jun 20, 2022 10:53 pm

[FIXED} Image scaling broken in freecad v0.20

Post by computer extreme »

Image scaling works fine in version 0.19 in the techdraw workbench.

Its broken in version 2.0

If you add a view to a page in techdraw, you cant scale it.
Last edited by Kunda1 on Mon Jul 04, 2022 8:11 pm, edited 1 time in total.
Reason: Added [FIXED] to thread title
User avatar
Kunda1
Veteran
Posts: 12738
Joined: Thu Jan 05, 2017 9:03 pm

Re: Image scaling broken in freecad v0.20

Post by Kunda1 »

@computer extreme opened a ticket issue #7066

Please note that we ask you to first verify on the forum and get the green light first from a dev or veteran to open a ticket. Also always paste your full About info.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
computer extreme
Posts: 2
Joined: Mon Jun 20, 2022 10:53 pm

Re: Image scaling broken in freecad v0.20

Post by computer extreme »

It was part of the bug report process
user1234
Veteran
Posts: 1737
Joined: Mon Jul 11, 2016 5:08 pm

Re: Image scaling broken in freecad v0.20

Post by user1234 »

I have not te newest (~3 weeks old) FreeCAD here, but the scaling works here. What not work, or better said, what the behavior is not really good, are the image boundaries. With the property Crop = true, it works. I also think this property for that is new (i can not verify that, just a guess). So it is not really a bug, but a feature, that the behavior is more naturally would be better. I think the best behavior is like the image plane from the image wb. Just load the image and scale it with is size with expressions. Also then you can scale it different in every direction, which will be a useful feature too (and it is also minimalist).

1.png
1.png (16.99 KiB) Viewed 447 times

Greetings
user1234

edit: replace word
User avatar
wandererfan
Veteran
Posts: 4795
Joined: Tue Nov 06, 2012 5:42 pm

Re: Image scaling broken in freecad v0.20

Post by wandererfan »

computer extreme wrote: Tue Jun 21, 2022 6:30 pm Image scaling works fine in version 0.19 in the techdraw workbench.

Its broken in version 2.0

If you add a view to a page in techdraw, you cant scale it.
This isn't much to go on. Are you talking about TechDraw_Symbol, TechDraw_Image or TechDraw_View?

Usually when somebody says they can't change the scale, the View's ScaleType property is set to Page. If you want to change the Scale of a single View, you need to set the ScaleType to Custom first.
user1234
Veteran
Posts: 1737
Joined: Mon Jul 11, 2016 5:08 pm

Re: Image scaling broken in freecad v0.20

Post by user1234 »

wandererfan wrote: Wed Jun 22, 2022 12:38 am This isn't much to go on. Are you talking about TechDraw_Symbol, TechDraw_Image or TechDraw_View?
TechDraw_Image (not tested the others at the moment.

see:
1.webm
(200.42 KiB) Downloaded 3 times
test_bitmap.FCStd
(2.52 KiB) Downloaded 2 times
bitmap.png
bitmap.png (27.41 KiB) Viewed 359 times


(ot: how to add a bitmap as file without showing it? Showing makes no sense here, sorry if the bitmap is annoying big).

Greetings
user1234
User avatar
wandererfan
Veteran
Posts: 4795
Joined: Tue Nov 06, 2012 5:42 pm

Re: Image scaling broken in freecad v0.20

Post by wandererfan »

user1234 wrote: Wed Jun 22, 2022 3:40 pm TechDraw_Image (not tested the others at the moment.
Well, I see a problem in Image in both 0.19 and 0.20, but it isn't that you can't scale the image. Changes to the width and height properties are ignored. So the scaled bitmap is cropped to the original size.

This needs to be fixed, but it doesn't sound like OP's complaint.
user1234
Veteran
Posts: 1737
Joined: Mon Jul 11, 2016 5:08 pm

Re: Image scaling broken in freecad v0.20

Post by user1234 »

wandererfan wrote: Wed Jun 22, 2022 8:32 pm Well, I see a problem in Image in both 0.19 and 0.20
Have not tried 0.19 yet.


wandererfan wrote: Wed Jun 22, 2022 8:32 pm but it isn't that you can't scale the image
As i wrote in the first post here, the scaling itself work, also i do not think that is a bug. Just a missing feature (to handle the width and height better). But that is really really minor.


wandererfan wrote: Wed Jun 22, 2022 8:32 pm ut it doesn't sound like OP's complaint
In the ticket there is "Image scaling broken". The meaning of broken can be interpreted from everyone somehow.


Greetings
user1234
User avatar
wandererfan
Veteran
Posts: 4795
Joined: Tue Nov 06, 2012 5:42 pm

Re: Image scaling broken in freecad v0.20

Post by wandererfan »

Image scaling should be fixed by git commit 11c6f4a9e9.
Post Reply