[Feature Request] Surface finish symbols [SOLVED]

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
bensay
Posts: 202
Joined: Wed Dec 22, 2021 8:14 pm
Location: Danmark
Contact:

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by bensay »

edi wrote: Sat Jul 30, 2022 3:35 pm If somebody wants to receive the source code, please tell me.
I won't promise anything, but i would gladly take a look at it. Also, it shouldn't be that you got Discord?
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by user1234 »

FBXL5 wrote: Sun Jul 31, 2022 10:49 pm Maybe the field could be split in two:
- One to choose Ra. Rz, or none to edit manually.
- and following a box with given values and the choice to type a value manually.
I would let the field empty for edit, because there is no need to make it more complex.


wandererfan wrote: Fri Jul 29, 2022 2:31 pm All yours. Let me know if you get stuck.
Time is my enemy. They saw i had a little time to do my own things, so they decided to bury more work on me.


Greetings
user1234
PitiBon
Posts: 3
Joined: Wed Jan 18, 2023 3:18 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by PitiBon »

I need to include surface roughness on drawings and tried version 1 and 3 of the macro in this thread and they don't work

I'm on Mac OS Monterey 12.5

and have Freecad 0.20.1

any pointers?
User avatar
NewJoker
Veteran
Posts: 3018
Joined: Sun Oct 11, 2020 7:49 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by NewJoker »

It’s a built-in tool in 0.21 dev version: TechDraw SurfaceFinishSymbol
User avatar
Cuq
Posts: 145
Joined: Tue Jul 06, 2021 10:07 am

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by Cuq »

NewJoker wrote: Fri Jan 20, 2023 12:28 am It’s a built-in tool in 0.21 dev version: TechDraw SurfaceFinishSymbol
Unfortunately the symbols are already obsolete the notation is no longer in accordance with ISO 25178-1 & ISO 21920-1

Geometrical product specifications (GPS) - Surface texture : profile - Part 1 : indication of surface texture Full sample notation
ISO21920-1.PNG
ISO21920-1.PNG (10.67 KiB) Viewed 999 times
Geometrical product specifications (GPS) - Surface texture : Area- Part 1 : indication of surface texture Full sample notation
ISO25178-1.PNG
ISO25178-1.PNG (5.05 KiB) Viewed 999 times
These notation are of course a full capability description sample notation but it would be nice to have the new standard Symbol for Area and Profile Surface Finish
Graphical Symbols Profile.PNG
Graphical Symbols Profile.PNG (43.01 KiB) Viewed 999 times
Graphical Symbols Area.PNG
Graphical Symbols Area.PNG (43.59 KiB) Viewed 999 times
edi
Posts: 481
Joined: Fri Jan 17, 2020 1:32 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by edi »

Do you just want the tool to be expanded by additional symbols, or more ?
User avatar
NewJoker
Veteran
Posts: 3018
Joined: Sun Oct 11, 2020 7:49 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by NewJoker »

Old symbols are still in use, likely more commonly than new ones. I definitely wouldn’t remove them, maybe add new versions if really needed.
edi
Posts: 481
Joined: Fri Jan 17, 2020 1:32 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by edi »

SurfaceSymbols05.png
SurfaceSymbols05.png (21.22 KiB) Viewed 840 times
Find attached version 5 of SurfaceSymbols.Macro extended by the desired icons.
SurfaceSymbols05.FCMacro
(11.41 KiB) Downloaded 34 times
TaskSurfaceFinishSymbols05.ui
(7.78 KiB) Downloaded 37 times
Installation:

Copy the two files SurfaceSymbols05.Macro and TaskSurfaceFinishSymbols05.ui into your macro directory. Usage is equal as in the older versions.

Please post ideas for improvements or issues.
User avatar
NewJoker
Veteran
Posts: 3018
Joined: Sun Oct 11, 2020 7:49 pm

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by NewJoker »

@edi I tested it, works great. Could you make a PR to add those new symbols to the built-in SurfaceFinishSymbol tool ?
User avatar
Cuq
Posts: 145
Joined: Tue Jul 06, 2021 10:07 am

Re: [Feature Request] Surface finish symbols [SOLVED]

Post by Cuq »

edi wrote: Sat Apr 15, 2023 2:49 pm Find attached version 5 of SurfaceSymbols.Macro extended by the desired icons.
SurfaceSymbols05.FCMacroTaskSurfaceFinishSymbols05.ui

You will Find herewith a version 06 ... Ra is written with upper case R and lower case a.
RaExemple.PNG
RaExemple.PNG (3.67 KiB) Viewed 762 times
From my point of view it should be more a free text than only the choice on the Ra ... In the ISO 21920-2 standard there are more than a hundred parameters. Limiting to one out of 100 is not to promote the use of this marco.
Liste.png
Liste.png (93.08 KiB) Viewed 762 times
Attachments
SurfaceSymbols06.FCMacro
(11.41 KiB) Downloaded 28 times
Post Reply