Cosmetic Vertex Alpha Release

Discussions about the development of the TechDraw workbench
User avatar
wandererfan
Posts: 3651
Joined: Tue Nov 06, 2012 5:42 pm

Cosmetic Vertex Alpha Release

Postby wandererfan » Sat May 25, 2019 1:05 pm

Preliminary (alpha) versions of TechDraw_CosmeticVertex, TechDraw_Midpoints and TechDraw_Quadrant are available in master branch.

These functions allow the creation of otherwise impossible dimensions.

Test reports are very welcome.
freecad-heini-1
Posts: 6590
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Cosmetic Vertex Alpha Release

Postby freecad-heini-1 » Sat May 25, 2019 1:17 pm

wandererfan wrote:
Sat May 25, 2019 1:05 pm
Preliminary (alpha) versions of TechDraw_CosmeticVertex, TechDraw_Midpoints and TechDraw_Quadrant are available in master branch.

These functions allow the creation of otherwise impossible dimensions.

Test reports are very welcome.
Thank you so much Wandererfan. Great and helpful cosmetic vertex.
vocx
Posts: 3289
Joined: Thu Oct 18, 2018 9:18 pm

Re: Cosmetic Vertex Alpha Release

Postby vocx » Sat May 25, 2019 6:11 pm

wandererfan wrote:
Sat May 25, 2019 1:05 pm
Preliminary (alpha) versions of TechDraw_CosmeticVertex, TechDraw_Midpoints and TechDraw_Quadrant are available in master branch.

These functions allow the creation of otherwise impossible dimensions.

Test reports are very welcome.
In the wiki page, I personally recommend you to avoid adding a "Note: introduced in version 0.19". This information is already provided by the right floating box, the "GuiCommand" template. Basically, you are duplicating the information unnecessarily.

In TechDraw Quadrant, the second note, "This tool can actually be used on any Edge, not just circles", should be in the "How to use" section as well. In my opinion, you should fully describe the tool in that section. "Notes" should be reserved for information that really can't be integrated easily into other sections.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
aapo
Posts: 102
Joined: Mon Oct 29, 2018 6:41 pm

Re: Cosmetic Vertex Alpha Release

Postby aapo » Fri May 31, 2019 12:47 pm

wandererfan wrote:
Sat May 25, 2019 1:05 pm
Preliminary (alpha) versions of TechDraw_CosmeticVertex, TechDraw_Midpoints and TechDraw_Quadrant are available in master branch.
Thanks a lot! This new functionality seems to fix many problem cases even in its preliminary alpha state! For example:
FreeCAD-filletmodel-TechDraw-CosmeticVertices.png
FreeCAD-filletmodel-TechDraw-CosmeticVertices.png (29.53 KiB) Viewed 592 times

I tested quadrants, midpoints, and arbitrary cosmeticvertices, and all of them worked the way I expected. So, seems good to me, notwithstanding the fact that I found no way to edit or remove any of the cosmeticvertices. Selecting a vertex and pressing delete removes the whole View, and removing vertices from the list in the View properties does nothing. I hope deleting CosmeticVertices will be added in the future, it'd make it easier to correct misplaced vertices. Also, adding "CosmeticEdges" with thin dot-dashed line between arbitrary vertices would be super helpful! :D

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16883 (Git)
Build type: Release
Branch: master
Hash: aedb888ae3bb001175fe86211b6cfb826e31a918
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
User avatar
wandererfan
Posts: 3651
Joined: Tue Nov 06, 2012 5:42 pm

Re: Cosmetic Vertex Alpha Release

Postby wandererfan » Fri May 31, 2019 3:46 pm

aapo wrote:
Fri May 31, 2019 12:47 pm
So, seems good to me, notwithstanding the fact that I found no way to edit or remove any of the cosmeticvertices. Selecting a vertex and pressing delete removes the whole View, and removing vertices from the list in the View properties does nothing. I hope deleting CosmeticVertices will be added in the future, it'd make it easier to correct misplaced vertices. Also, adding "CosmeticEdges" with thin dot-dashed line between arbitrary vertices would be super helpful! :D
Glad you like it. CosmeticEraser is being tested. CosmeticEdges are in development too.
triplus
Posts: 9278
Joined: Mon Dec 12, 2011 4:45 pm

Re: Cosmetic Vertex Alpha Release

Postby triplus » Wed Aug 07, 2019 2:52 pm

Great additions!