LeaderLine and RichTextAnno Alpha Release

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Syres
Veteran
Posts: 2900
Joined: Thu Aug 09, 2018 11:14 am

Re: LeaderLine and RichTextAnno Alpha Release

Post by Syres »

wandererfan wrote: Sun May 19, 2019 5:29 pm Regression in positioning code should be fixed by git commit 8ef3f13fbb
That's working fine now, thanks for the quick fix.

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16808 (Git)
Build type: Release
Branch: master
Hash: 0e17c22e3995693e1e329ee18af8c972a81fe831
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by bitacovir »

The problem with the RichText Editor is fixed. But still, there are problems with the DrawLeaderLine: the arrow does not move when there is an edition, and the changes are lost when you close the page.
DrawLeaderLine2.gif
DrawLeaderLine2.gif (622.9 KiB) Viewed 1512 times
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16808 (Git)
Build type: Release
Branch: master
Hash: 0e17c22e3995693e1e329ee18af8c972a81fe831
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by wandererfan »

bitacovir wrote: Tue May 21, 2019 3:05 pm The problem with the RichText Editor is fixed. But still, there are problems with the DrawLeaderLine: the arrow does not move when there is an edition, and the changes are lost when you close the page.
There are a couple of things going on here.
1) it doesn't like having the point where the line connects to the View changed. I have to fix that.
2) the button "escape edit" is meant to exit without saving. I've been using RMB to save and exit. I'll fix that so there is 1 button for "save changes" and another for "discard changes".

Once again, thanks for testing. It is a huge help to me.
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by wandererfan »

Edit first vertex fix and save/discard buttons in dialog implemented in this git commit bf38ae958f
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by bitacovir »

wandererfan wrote: Sat May 25, 2019 12:59 pm Edit first vertex fix and save/discard buttons in dialog implemented in this git commit bf38ae958f
Hi. Thanks for fixing them and for your hard work. However, I detected two problems:

1) If you change the position of the start symbol point, the "Discard Changes" button does not work as expected.
2) Tick symbol is shown in a large size.

Discard Changes button problem:
DrawLeaderLine3.gif
DrawLeaderLine3.gif (458 KiB) Viewed 1384 times
Tick symbol problem:
FreeCAD_2019-05-29_11-39-06.png
FreeCAD_2019-05-29_11-39-06.png (57.37 KiB) Viewed 1384 times
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16878 (Git)
Build type: Release
Branch: master
Hash: 50f91840d677ba77d3a938d9ac0aa73f6a9f12d4
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by wandererfan »

bitacovir wrote: Wed May 29, 2019 3:50 pm 1) If you change the position of the start symbol point, the "Discard Changes" button does not work as expected.
2) Tick symbol is shown in a large size.
Should be fixed by git commit 74737f71fd and git commit be257182ba.

Thanks for testing.
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by bitacovir »

Good. I confirm they were fixed.

I found two more things for LeaderLine.
1) In the property table, the option "Caption". If I write something, nothing happens. What is its function?
2) In the property table, the option "Scalable". If I change it to "True", the leaderLine does not scale when I scale the View parent. It disappears.

There is a problem with the RichTextAnno again. The format change when I select texts in the window. Better an animation:
RichText2.gif
RichText2.gif (907.99 KiB) Viewed 1310 times
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16883 (Git)
Build type: Release
Branch: master
Hash: aedb888ae3bb001175fe86211b6cfb826e31a918
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by wandererfan »

bitacovir wrote: Sat Jun 01, 2019 12:34 am 1) In the property table, the option "Caption". If I write something, nothing happens. What is its function?
Caption doesn't really apply to Leaders (or Dimensions, Balloons, etc). It is used to add a small bit of text to a View that remains on the page when frames are hidden. Hiding this property for the objects where it doesn't make sense is on my list.
bitacovir wrote: Sat Jun 01, 2019 12:34 am 2) In the property table, the option "Scalable". If I change it to "True", the leaderLine does not scale when I scale the View parent. It disappears.
I suspect that it didn't disappear, but moved to somewhere off the page. I haven't spent much time on scaling the leader as I wasn't sure if it made sense. Better get on that.
bitacovir wrote: Sat Jun 01, 2019 12:34 am There is a problem with the RichTextAnno again. The format change when I select texts in the window. Better an animation:
Maybe borrowing that code wasn't such a good idea. :( I'll take a look at it.
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by wandererfan »

bitacovir wrote: Sat Jun 01, 2019 12:34 am 1) In the property table, the option "Caption". If I write something, nothing happens. What is its function?
2) In the property table, the option "Scalable". If I change it to "True", the leaderLine does not scale when I scale the View parent. It disappears.
1) should be fixed by:
commit 0c429e3bc6 Fix regression in Caption handling
commit 71a095360a Hide Caption property where not applicable

2) having trouble with repeatability on this one. It seems to work most of the time, but I can't find the pattern for the failures.
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: LeaderLine and RichTextAnno Alpha Release

Post by bitacovir »

wandererfan wrote: Tue Jun 04, 2019 11:47 am
2) having trouble with repeatability on this one. It seems to work most of the time, but I can't find the pattern for the failures.
1) Draw a wall in ArchWB >select the wall and create an Arch Section
2) Create a default page in TechDraw > Select the Arch section and create a Section plane View
3) Select the section Plane view and change the scale to 0.03
4) Select the section plane view and create a LeaderLine
5) Select the leader line and switch the Scalable property to True. The line disappears in the page view.
Here I share an example file.
pruebaLeaderLine.FCStd
(27.77 KiB) Downloaded 30 times
LeaderLineGone.gif
LeaderLineGone.gif (338.38 KiB) Viewed 1213 times
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16883 (Git)
Build type: Release
Branch: master
Hash: aedb888ae3bb001175fe86211b6cfb826e31a918
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Post Reply