[Techdraw] Two issues with Chain Dimensions [1 of 2 fixed]

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

[Techdraw] Two issues with Chain Dimensions [1 of 2 fixed]

Post by balrobs »

Today I discovered two issues with chain dimensions:
  • when creating vertical or horizontal chain dimensions their dimension lines aren't prefectly aligned. The effect is more visible for the vertical dimensions than for the horizontal dimensions. Maybe a cause for this problem is that some dimensions have a comma symbol and other not.
    screenshot_03.PNG
    screenshot_03.PNG (40.11 KiB) Viewed 1249 times
  • the command Techdraw_ToggleFrame messes up some dimension position. This is very annoying, because you have to do the same work over and over again.
    screenshot_06.PNG
    screenshot_06.PNG (58.49 KiB) Viewed 1249 times
Here my system info:

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.29177 (Git)
Build type: Release
Branch: releases/FreeCAD-0-20
Hash: 68e337670e227889217652ddac593c93b5e8dc94
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.2
Locale: German/Germany (de_DE)
Installed mods: 
  * Assembly3 0.11.3
  * BIM 2021.12.0
  * ExtremeProDark 1.0.0
  * FreeCAD_SketchArch
  * Help 1.0.3
  * ProDarkThemePreferencePack 1.0.0
and here my test file:
myTest01.FCStd
(44.02 KiB) Downloaded 20 times
Last edited by balrobs on Sat Aug 27, 2022 8:45 am, edited 2 times in total.
User avatar
Shalmeneser
Veteran
Posts: 9475
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: [Techdraw] Issues with Chain Dimensions

Post by Shalmeneser »

Except for 190 and 120, your other dimensions mean nothing.
You should use the same dimensions as in the master sketch.
Attachments
myTest01(1)_SHALM.FCStd
(32.44 KiB) Downloaded 15 times
Capture d’écran 2022-08-09 210600.jpg
Capture d’écran 2022-08-09 210600.jpg (65.25 KiB) Viewed 1233 times
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [Techdraw] Issues with Chain Dimensions

Post by balrobs »

Shalmeneser wrote: Tue Aug 09, 2022 6:56 pm Except for 190 and 120, the other dimensions mean nothing.
You should use the same dimensions as in the master sketch.
Thank you @Shalmeneser for your response.
You're right that my dimensions don't make sense for this test object.
Nevertheless, in my opinion, the observed behavior remains undesirable, regardless of whether the dimensions makes sense or not.
Cheers
Edit: misspelling
User avatar
Shalmeneser
Veteran
Posts: 9475
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: [Techdraw] Issues with Chain Dimensions

Post by Shalmeneser »

I confirm your problem.
* Horizontal : TechDraw_ExtensionCreateHorizChainDimension and TechDraw_ExtensionPosHorizChainDimension : OK
* Vertical : TechDraw_ExtensionCreateVertChainDimension and TechDraw_ExtensionPosVertChainDimension : Problem with aligment

Moreover, it's sad that after creating Chain dimension, you need to reselect all the dimensions to position them.

Code: Select all

OS: Windows 10 Version 1809
Word size of FreeCAD: 64-bit
Version: 0.21.29923 (Git)
Build type: Release
Branch: master
Hash: 30cb46cc5f630c97311162413b68edcff95db481
Python 3.10.5, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.2
Locale: French/France (fr_FR)
Installed mods: 
  * fasteners 0.3.50
  * fcgear 1.0.0
  * Manipulator 1.4.9
  * sheetmetal 0.2.53
Attachments
Capture d’écran 2022-08-10 020205.jpg
Capture d’écran 2022-08-10 020205.jpg (61.45 KiB) Viewed 1114 times
TechDrawChain.FCStd
(18.73 KiB) Downloaded 12 times
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [Techdraw] Issues with Chain Dimensions

Post by wandererfan »

balrobs wrote: Tue Aug 09, 2022 6:47 pm Today I discovered two issue with chain dimensions:
Is there a trick to making this happen? I can't recreate either.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [Techdraw] Issues with Chain Dimensions

Post by wandererfan »

Shalmeneser wrote: Wed Aug 10, 2022 12:09 am * Vertical : TechDraw_ExtensionCreateVertChainDimension and TechDraw_ExtensionPosVertChainDimension : Problem with aligment
It looks like it is aligning on the centre of the dimension text, which will not align the arrows unless the texts are exactly the same size. Aligning to the right edge would be better, but even that wouldn't work if the format was different.
Moreover, it's sad that after creating Chain dimension, you need to reselect all the dimensions to position them.
Yes, the extension functions need some work.
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [Techdraw] Issues with Chain Dimensions

Post by balrobs »

wandererfan wrote: Wed Aug 10, 2022 12:41 am It looks like it is aligning on the centre of the dimension text, which will not align the arrows unless the texts are exactly the same size. Aligning to the right edge would be better, but even that wouldn't work if the format was different.
Yes it seems like the alignmemt reffers to the center of the dimension texts.
For horizontal dimensions this causes only minor problems if there are numbers with and without decimal places.
For vertical dimensions this leads to major problems as shown by Shalmenser.
IMO the alignment should reffer to the dimension line below the dimension text.
Cheers
Last edited by balrobs on Wed Aug 10, 2022 6:17 am, edited 1 time in total.
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [Techdraw] Issues with Chain Dimensions

Post by balrobs »

wandererfan wrote: Wed Aug 10, 2022 12:32 am Is there a trick to making this happen? I can't recreate either.
Now I think I understand the problem better.
To make this happen you can follow this steps:
  1. create a horizontal or vertical chain dimension
  2. press STRG and select all dimensions of the chain by clicking one after the other
  3. click on one of the dimensions and drag them all together to a new desired position
  4. click on somewhere else to deselect all dimensions
  5. press the button TechDraw_ToggleFrame
What you should see:
  • only the dimension used for the drag operation in step 3 retains its correct position
  • all other dimensions are reset to their original positions
Cheers
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [Techdraw] Issues with Chain Dimensions

Post by wandererfan »

balrobs wrote: Wed Aug 10, 2022 5:43 am [*] only the dimension used for the drag operation in step 3 retains its correct position
[*] all other dimensions are reset to their original positions
All the moved dimensions should stay in the right place now - git commit cb96332a641.

The other stuff needs some thought.
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [Techdraw] Issues with Chain Dimensions

Post by balrobs »

wandererfan wrote: Wed Aug 10, 2022 6:12 pm All the moved dimensions should stay in the right place now - git commit cb96332a641.
Wow, thank you su much for reacting so quickly to problems and for driving development at this pace. :o
I will test the changes and let you know.
Cheers
Post Reply