Rich texteditor Techdraw icons not readable on dark themes.

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Rich texteditor Techdraw icons not readable on dark themes.

Post by MisterMaker »

I am replacing all the Techdraw icons with my own and came across the rich text editor this editor has black text icons and aren't really readable in any dark theme.
Icons that I cannot find in the icon searcher and so I can't replace them.
I think they are maybe default Qt icons and need to be changed in the theme file?
Image
This also happens in other dark theme's:
Image
Has anyone any idea's if we can do something about it?
Small note the other icons aren't listed also in the icon browser.
For testing purpose I tested it in 0.2

Code: Select all

[code]
OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.28886 (Git)
Build type: Release
Branch: master
Hash: a564d5ced7aecf320a0ac2d73f824a3dc7861eb3
Python 3.8.10, Qt 5.15.3, Coin 4.0.1, OCC 7.5.3
Locale: Dutch/Netherlands (nl_NL)
Installed mods: 
  * Assembly3 0.11.3
  * Behave-Dark-Colors 0.0.1
  * FeedsAndSpeeds 0.4.0
  * FEM_FrontISTR 0.1.0
  * lattice2 1.0.0
  * ProDarkThemePreferencePack 1.0.0
  * SelectorToolbar
  * sheetmetal 0.2.49
  * ToolbarStyle
[/code]
Last edited by MisterMaker on Tue May 31, 2022 10:47 pm, edited 3 times in total.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Rich exteditor Techdraw icons are black.

Post by Roy_043 »

The icons seem to be here: src/Mod/TechDraw/Gui/Resources/icons/MRTE/. See also Artwork_TechDraw. But I do not know if, and how, they can be replaced.
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Rich exteditor Techdraw icons are black.

Post by MisterMaker »

@Roy_043 That is a useful wiki, I had not been there haha oops! Now I at least know what too look for. Although I get no results in the icon browser.

Does anyone know if we can fix this in the theme files without changing the looks of the theme or does this has to be fixed on the Techdraw workbench?
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Rich texteditor Techdraw icons not readable on dark themes.

Post by Kunda1 »

MisterMaker wrote: Tue May 31, 2022 9:36 pm Does anyone know if we can fix this in the theme files without changing the looks of the theme or does this has to be fixed on the Techdraw workbench?
@chennes any idea?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Rich texteditor Techdraw icons not readable on dark themes.

Post by chennes »

Nope, no clue! Sorry!
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Rich texteditor Techdraw icons not readable on dark themes.

Post by MisterMaker »

I added a white background to the icons and opened an issue on github.
https://github.com/FreeCAD/FreeCAD/issues/6988
I wouldn't mind publishing the icons myself but it's scary.
Attachments
srcModTechDrawGuiResourcesiconsMRTE_whiteback.zip
(32.17 KiB) Downloaded 36 times
User avatar
wandererfan
Veteran
Posts: 6265
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Rich texteditor Techdraw icons not readable on dark themes.

Post by wandererfan »

merged to master - git commit 1b65b3f600
Post Reply