New ProDark Theme with 4k small text Mod

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

Kunda1 wrote: Fri Mar 05, 2021 7:22 pm Maybe we should make a macro that auto-changes all these in the user.cfg file?
mario52 wrote: pinged by pinger macro
@mario52 is there a macro that exists for this?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Kunda1 wrote: Fri Mar 05, 2021 7:22 pm
turn211 wrote: Fri Mar 05, 2021 6:35 pm Glad you got it sorted out. Yes all those colour choices can be changed in Preferences. If your happy great, but you could use the ProDark Theme colours listed in https://forum.freecadweb.org/viewtopic. ... 80#p482055
Maybe we should make a macro that auto-changes all these in the user.cfg file?
Sounds good by me. I haven't used Macros myself. Still learning GitHub. :lol: New PR 4586
User avatar
Petrikas
Posts: 122
Joined: Sat Dec 05, 2020 8:05 pm

Re: New ProDark Theme with 4k small text Mod

Post by Petrikas »

Hello,
Just a heads up that QPushButton min-width: 70px; doesn't play perfectly well with some of the third-party add-ons (I.e. Defeaturing Tools). This could potentially interfere with anything that is using PushButtons. Maybe it would be a good idea not to force the width?
---
sc 2021-03-14 00_22_18.jpg
sc 2021-03-14 00_22_18.jpg (28.75 KiB) Viewed 3526 times
I sometimes make FreeCAD Tutorials | VertUI | MidnightUI
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

Petrikas wrote: Sat Mar 13, 2021 10:25 pm Just a heads up
Thanks for communicating this. Both of you are doing important work and it makes me happy to see that there is an open channel of communication between freecad master branch and linkstage3. :D
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Petrikas wrote: Sat Mar 13, 2021 10:25 pm Hello,
Just a heads up that QPushButton min-width: 70px; doesn't play perfectly well with some of the third-party add-ons (I.e. Defeaturing Tools). This could potentially interfere with anything that is using PushButtons. Maybe it would be a good idea not to force the width?
---
sc 2021-03-14 00_22_18.jpg
Thanks for the heads up. Never used this add-on. My bad. Will still use QPushButton min-width: 70px;as it's a design element of the ProDark theme but will isolate only the widgets that need this style instead of globally. Taking a guess this Add-on seems to have a maximum frame or grid size set as dialog can't expand. Other Add-ons don't have this limitation. I see though it is like a calculator so must be intentional. With these constraints i have styled accordingly but will have to clean up code. Will release soon.
Attachments
Defeaturing_Tools_Add_on.png
Defeaturing_Tools_Add_on.png (181.73 KiB) Viewed 3461 times
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: New ProDark Theme with 4k small text Mod

Post by Kunda1 »

easyw wrote: pinged by pinger macro
@easyw is the author of defeaturing wb. Just giving a heads-up
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
easyw
Posts: 16
Joined: Tue Feb 05, 2013 10:12 am

Re: New ProDark Theme with 4k small text Mod

Post by easyw »

turn211 wrote: Sun Mar 14, 2021 6:52 am Thanks for the heads up. Never used this add-on. My bad. Will still use QPushButton min-width: 70px;as it's a design element of the ProDark theme but will isolate only the widgets that need this style instead of globally. Taking a guess this Add-on seems to have a maximum frame or grid size set as dialog can't expand. Other Add-ons don't have this limitation. I see though it is like a calculator so must be intentional. With these constraints i have styled accordingly but will have to clean up code. Will release soon.
please have a look also to:
1) Manipulator WB
2) kicadStepUp WB
they are based also on the same structure of Defeaturing WB
-
addons.PNG
addons.PNG (489.06 KiB) Viewed 3356 times
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

easyw wrote: Mon Mar 15, 2021 9:42 am please have a look also to:
1) Manipulator WB
2) kicadStepUp WB
they are based also on the same structure of Defeaturing WB
-
addons.PNG
All Add-ons themed with workarounds. Looks good. Since none of the QPushButtons had text but used icons and these Add-ons used a grid format QToolbarButtons would been a better/easier solution IMHO. Anyway all fixed now. Cheers!
nice.png
nice.png (382.43 KiB) Viewed 3305 times
Add-ons_themed.png
Add-ons_themed.png (280.42 KiB) Viewed 3305 times
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: New ProDark Theme with 4k small text Mod

Post by turn211 »

Lots of handsome improvements including Add-ons theming, Button contrast usability theming and more. I'll let everone try it out before submitting a PR. Get it at https://github.com/turn211/ProDark-FreeCAD-theme More pics to come. :)
nice.png
nice.png (382.43 KiB) Viewed 3300 times
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: New ProDark Theme with 4k small text Mod

Post by bitacovir »

The Image Scaling window (Image Workbench) does not have the text in ProDark Theme.

- Change to ProDark Theme
- Open Image workbench
- Click on Image Scaling icon on the toolbar. The window that shows up does not have text...

Image Scaling window with ProDark theme:
freecad_EgE6SlcCn5.png
freecad_EgE6SlcCn5.png (55.83 KiB) Viewed 3262 times
.
.
Image Scaling window with no style sheet:
freecad_2SHIWSmjMT.png
freecad_2SHIWSmjMT.png (52.54 KiB) Viewed 3262 times
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24267 (Git)
Build type: Release
Branch: master
Hash: b2ca86d8d72b636011a73394bf9bcdedb3b109b7
Python version: 3.8.8
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
Post Reply