SOLVED : Addon Manager - BUG.

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
Post Reply
keithsloan52
Veteran
Posts: 2756
Joined: Mon Feb 27, 2012 5:31 pm

SOLVED : Addon Manager - BUG.

Post by keithsloan52 »

There appears to be a bug in the Addon Manager in that it does not handle github repositories where a submodule has been removed.
Outputs error and then hangs. Restarting FreeCAD and the workbench is okay but very off-putting for users.

I hate git submodules at the best of times and would like advice on restoring things so users don't get a failure.

Really could do with FreeCAD having some sort of emergency fix facility.

Code: Select all

13:11:59  Cloning repo...
13:11:59  Lock acquired...
13:12:03  Initial clone complete...
13:12:03  Traceback (most recent call last):
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/Mod/AddonManager/addonmanager_workers.py", line 982, in run
13:12:03      self.run_git(target_dir)
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/Mod/AddonManager/addonmanager_workers.py", line 1016, in run_git
13:12:03      self.run_git_clone(clonedir)
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/Mod/AddonManager/addonmanager_workers.py", line 1102, in run_git_clone
13:12:03      if repo.submodules:
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/lib/python3.9/site-packages/git/repo/base.py", line 368, in submodules
13:12:03      return Submodule.list_items(self)
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/lib/python3.9/site-packages/git/util.py", line 1103, in list_items
13:12:03      out_list.extend(cls.iter_items(repo, *args, **kwargs))
13:12:03    File "/Applications/FreeCAD_0.20.app/Contents/Resources/lib/python3.9/site-packages/git/objects/submodule/base.py", line 1266, in iter_items
13:12:03      sm._name = n
13:12:03  AttributeError: 'Tree' object has no attribute '_name'
keithsloan52
Veteran
Posts: 2756
Joined: Mon Feb 27, 2012 5:31 pm

Re: SOLVED : Addon Manager - BUG.

Post by keithsloan52 »

Submodule was not completely removed.
Post Reply