Contributing without github account

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

PrzemoF wrote: Wed Jul 13, 2022 9:40 pm A gentle reminder. Rebased on the latest master.
Merged.

Please always use "@wmayer" when you have something to merge as otherwise I won't be notified.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

Will do, thank you!!!
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

@wmayer
Can I kindy ask to merge this branch? https://gitlab.com/PrzemoF/FreeCAD/-/co ... pr_fix_v55
Alternatively https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v55
Or just pick this commit: https://github.com/PrzemoF/FreeCAD/comm ... 28f825efef

Not sure what's the easiest. Thank you!
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

Done.
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Contributing without github account

Post by adrianinsaval »

PrzemoF wrote: Wed Dec 07, 2022 8:23 pm Alternatively https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v55
I don't mean to complain but it would seem you do have and use a github account then, any particular reason why you don't make a PR from there?
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

See rhe OP. I'm not willing to play by MS rules just because they bought github :mrgreen: . I can't login without some stupid verification. If I was not contributing to FreeCAD the account would be closed by now. I moved all my toys ro gitlab. I still can push commits to github from command line without going through the verification.

Thank you Werner for merging the commit!

Anyway it's just my twisted view. I also use mastodon for years instead of twitter :mrgreen:
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Contributing without github account

Post by adrianinsaval »

See rhe OP.
of course, silly me :oops:
I have no objection to your decision, I perfectly understand aversion to MS. In recent discussion about the contribution process I advocated for allowing cases like yours instead of going github or nothing.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

@wmayer

Can you merge this one please? https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v58

It's a simple change to macros - they statred to catch some random stuff, derailing the COPR builds
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

Merged.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

Another fix: https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v59 - can you merge it please?
Thank you @mr-miky !!!
Post Reply