PR #3794 - pad in any direction

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: PR #3794 - pad in any direction

Post by wmayer »

uwestoehr wrote: Sat Sep 12, 2020 6:58 pm
wmayer wrote: Sat Sep 12, 2020 2:52 pm When using the option Two Lengths then the length in opposite direction is incorrect.
I was not aware of this yet. I am currently abroad and will have a look Monday evening to reproduce and fix it.
https://forum.freecadweb.org/viewtopic. ... 62#p430027
jaisejames
Posts: 384
Joined: Sat Sep 24, 2016 6:51 am

Re: PR #3794 - pad in any direction

Post by jaisejames »

If upto face can be extented to pipe connect option(in part work bench), it will be useful for multiple faces support.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR #3794 - pad in any direction

Post by uwestoehr »

wmayer wrote: Sat Sep 12, 2020 2:52 pm When using the option Two Lengths then the length in opposite direction is incorrect.
Thanks for your fix.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR #3794 - pad in any direction

Post by uwestoehr »

wmayer wrote: Sat Sep 12, 2020 2:52 pm What's not working yet are the options Up to first and Up to last
I tested again and cannot reproduce this. Here is an example file:
Pad-Test.FCStd
testfile
(60.23 KiB) Downloaded 175 times
With this everything works fine:
Se2eRZa379.gif
Se2eRZa379.gif (191.65 KiB) Viewed 9101 times
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR #3794 - pad in any direction

Post by uwestoehr »

OK, it strongly depends on the direction. Here another example that works:
rJwt2Z4Io8.gif
rJwt2Z4Io8.gif (142.92 KiB) Viewed 9097 times
If you change there the x coordinate to -1.000 (testfile
Pad-Test.FCStd
testfile
(142.24 KiB) Downloaded 187 times
) then "to first still works, while "to last" fails.
I have no clue yet, what causes this. I'll have a look as soon as I find the time.
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: PR #3794 - pad in any direction

Post by wmayer »

As previously said it's problem that has existed before. The point is that a ray is used to find an intersection with the nearest/farthest face and when the supposed face is too small the chance is low to find this intersection. If a custom direction is used the chance is even lower.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR #3794 - pad in any direction

Post by uwestoehr »

wmayer wrote: Mon Sep 14, 2020 8:53 pm The point is that a ray is used to find an intersection with the nearest/farthest face and when the supposed face is too small the chance is low to find this intersection.
I am new in this field. I just thought one goes into the pad direction and check step by step for a face. Therefore I wondered why the area of the face is important. But OK, since OCC does not support multiple bodies the pad must hit the face to form a single body.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR #3794 - pad in any direction

Post by uwestoehr »

Well, I see now that the limitation in finding the faces is already documented: https://wiki.freecadweb.org/PartDesign_Pad#Limitations
Post Reply