Page 2 of 2

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 1:48 pm
by openBrain
wmayer wrote: Thu Jul 30, 2020 8:17 am Part of your PR is this commit: https://github.com/FreeCAD/FreeCAD/pull ... 68f133d0ea
What's the point about it? The commit message is "Merge branch 'master' of github.com:FreeCAD/FreeCAD into PD-patterning".
I didn't tested what vocx said above, but I know this kind of commit is always created when one update an own branch versus FreeCAD master using the online Github functions. IIRC, there isn't any mean to update a fork on the website, so you actually have to use this merging commit. ;)

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 1:57 pm
by wmayer
I know about these merge commits but the change on the file FeatureTransformed.cpp where is this coming from? The file hasn't been touched for several weeks.

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 4:37 pm
by uwestoehr
wmayer wrote: Thu Jul 30, 2020 8:17 am Part of your PR is this commit: https://github.com/FreeCAD/FreeCAD/pull ... 68f133d0ea
What's the point about it?
Uh, this should not have happened. Sorry. (I didn't noticed this, just made a merge commit but can imagine why this slipped in.)

However, this PR is more or less required to make my PR really usable:
https://github.com/FreeCAD/FreeCAD/pull/3741
because without this PR all operations containing primitives wouldn't pattern. (E.g. In my real-life use cases I have to pattern primitives in combination with subtractive features.)

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 4:39 pm
by uwestoehr
wmayer wrote: Thu Jul 30, 2020 12:56 pm With git commit 94ca4388e you can move the items directly with the mouse.
many thanks!

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 4:55 pm
by uwestoehr
chrisb wrote: Thu Jul 30, 2020 7:25 am Here is the example (didn't have access to FreeCAD sooner).
Thanks, I understand now the issue.
Thanks to Werner's today's additions one can now change the order in the dialog list, but it is not yet taken into account, meaning, if you accept the dialog and reopen it, it still shows the old order -> I'll have a look at the weekend.

Re: PR #3748 allow multiselection on creation of pattern

Posted: Thu Jul 30, 2020 9:18 pm
by chrisb
Thanks!

Re: PR #3748 allow multiselection on creation of pattern

Posted: Fri Jul 31, 2020 1:06 am
by uwestoehr
uwestoehr wrote: Thu Jul 30, 2020 4:55 pm one can now change the order in the dialog list, but it is not yet taken into account, meaning, if you accept the dialog and reopen it, it still shows the old order -> I'll have a look at the weekend.
Here is the PR: https://github.com/FreeCAD/FreeCAD/pull/3760

With that PR you can now do this:
screencast
screencast
jlXaIvWrYy.gif (116.21 KiB) Viewed 9952 times

Re: PR #3748 allow multiselection on creation of pattern

Posted: Fri Jul 31, 2020 11:27 am
by chrisb
Great!