I didn't tested what vocx said above, but I know this kind of commit is always created when one update an own branch versus FreeCAD master using the online Github functions. IIRC, there isn't any mean to update a fork on the website, so you actually have to use this merging commit.wmayer wrote: ↑Thu Jul 30, 2020 8:17 am Part of your PR is this commit: https://github.com/FreeCAD/FreeCAD/pull ... 68f133d0ea
What's the point about it? The commit message is "Merge branch 'master' of github.com:FreeCAD/FreeCAD into PD-patterning".
PR #3748 allow multiselection on creation of pattern
Re: PR #3748 allow multiselection on creation of pattern
Re: PR #3748 allow multiselection on creation of pattern
I know about these merge commits but the change on the file FeatureTransformed.cpp where is this coming from? The file hasn't been touched for several weeks.
Re: PR #3748 allow multiselection on creation of pattern
Uh, this should not have happened. Sorry. (I didn't noticed this, just made a merge commit but can imagine why this slipped in.)wmayer wrote: ↑Thu Jul 30, 2020 8:17 am Part of your PR is this commit: https://github.com/FreeCAD/FreeCAD/pull ... 68f133d0ea
What's the point about it?
However, this PR is more or less required to make my PR really usable:
https://github.com/FreeCAD/FreeCAD/pull/3741
because without this PR all operations containing primitives wouldn't pattern. (E.g. In my real-life use cases I have to pattern primitives in combination with subtractive features.)
Re: PR #3748 allow multiselection on creation of pattern
many thanks!wmayer wrote: ↑Thu Jul 30, 2020 12:56 pm With git commit 94ca4388e you can move the items directly with the mouse.
Re: PR #3748 allow multiselection on creation of pattern
Thanks, I understand now the issue.
Thanks to Werner's today's additions one can now change the order in the dialog list, but it is not yet taken into account, meaning, if you accept the dialog and reopen it, it still shows the old order -> I'll have a look at the weekend.
Re: PR #3748 allow multiselection on creation of pattern
Thanks!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: PR #3748 allow multiselection on creation of pattern
Re: PR #3748 allow multiselection on creation of pattern
Great!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.