TechDraw: The People's Republic of China Templates A serial

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
felixlee868
Posts: 126
Joined: Wed Jul 03, 2019 8:15 am

TechDraw: The People's Republic of China Templates A serial

Post by felixlee868 »

Hi

I worked for the People's Republic of China State standard template files. The files only for A serial page size.

please pull branch felixlee from. https://www.95839.com/freecad.git/
chrisb
Veteran
Posts: 53922
Joined: Tue Mar 17, 2015 9:14 am

Re: TechDraw: The People's Republic of China Templates A serial

Post by chrisb »

Following the link I get an empty page.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
felixlee868
Posts: 126
Joined: Wed Jul 03, 2019 8:15 am

Re: TechDraw: The People's Republic of China Templates A serial

Post by felixlee868 »

use git clone command.


git clone https://www.95839.com/freecad.git

git checkout origin/felixlee -b zhcn
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: TechDraw: The People's Republic of China Templates A serial

Post by PrzemoF »

@felixlee868: can you upload it to github and make a pull request? That's the standard way of adding code to FreeCAD. The pull request then goes through a series of automated builds and tests to make sure your changes doesn't break existing code.

Please let me know if you need more detailed info how to do it.
felixlee868
Posts: 126
Joined: Wed Jul 03, 2019 8:15 am

Re: TechDraw: The People's Republic of China Templates A serial

Post by felixlee868 »

Ok

The GitHub URL is: https://github.com/felixlee868/freecad
Please checkout branch: felixlee
please merge to master branch for the files

Due to my git repo server in China, the network not so faster. I have pull the branch to my GitHub account.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: TechDraw: The People's Republic of China Templates A serial

Post by PrzemoF »

Great! Now you can login to your github account and make the pull request. Switch to your branch and click button "New pull request". That will trigger the code tests.
felixlee868
Posts: 126
Joined: Wed Jul 03, 2019 8:15 am

Re: TechDraw: The People's Republic of China Templates A serial

Post by felixlee868 »

Hi

I have merge branch felixlee to master on https://github.com/felixlee868/freecad
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: TechDraw: The People's Republic of China Templates A serial

Post by Kunda1 »

felixlee868 wrote: Wed Jul 03, 2019 12:57 pm I have merge branch felixlee to master on https://github.com/felixlee868/freecad
This is not what @sgrogan meant.
You keep the branch on your fork and you add FreeCAD/FreeCAD as a remote.
Then you submit a PR to FreeCAD/FreeCAD

Checkout https://www.freecadweb.org/wiki/Source_ ... ut_Remotes
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
felixlee868
Posts: 126
Joined: Wed Jul 03, 2019 8:15 am

Re: TechDraw: The People's Republic of China Templates A serial

Post by felixlee868 »

It is hard for old man to found the git function on GitHub. I have done the next steps:

1 fork project from FreeCAD/FreeCAD
2 upload my added files and directory in FreeCAD/src directory
3 create pull request on GitHub

I don't know if the process is ok for push my patch for FreeCAD project.
Post Reply