(WORKAROUND) Bug or operator error in arch?

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
thomas-neemann
Veteran
Posts: 11801
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

(WORKAROUND) Bug or operator error in arch?

Post by thomas-neemann »

when i want to add another beam (not in a main workplane) in this way



https://www.youtube.com/watch?v=nf5NX2g93u8

phpBB [video]





the result is different than expected


Can anybody confirm this?

ko1519.FCStd
(9.43 KiB) Downloaded 32 times
OS: Ubuntu 20.04.1 LTS (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.20.28793 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 5386d4e)
Hash: 5386d4ed864cd03edd026e1d3d128cccedf568df
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: German/Germany (de_DE)
Last edited by thomas-neemann on Tue Jul 05, 2022 5:53 am, edited 2 times in total.
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
chrisb
Veteran
Posts: 53938
Joined: Tue Mar 17, 2015 9:14 am

Re: Bug or operator error in arch?

Post by chrisb »

How about loosing a few words here on what you did and what you are expecting? Youtube is not everybody's darling. The model looks ok, and perhaps you only have to rework your expectations.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
thomas-neemann
Veteran
Posts: 11801
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: Bug or operator error in arch?

Post by thomas-neemann »

chrisb wrote: Sun May 08, 2022 3:17 pm How about loosing a few words here on what you did and what you are expecting? ..
here is an attempt without youtube

If I enter a value in this situation,
1.png
1.png (192.61 KiB) Viewed 1448 times


this is the result.

ko.png
ko.png (5.34 KiB) Viewed 1448 times

that's what I would expect
2.png
2.png (9.11 KiB) Viewed 1448 times
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
chrisb
Veteran
Posts: 53938
Joined: Tue Mar 17, 2015 9:14 am

Re: Bug or operator error in arch?

Post by chrisb »

It looks as if you didn't enter the second point and then it is created towards the current position of the mouse pointer. Doesn't look really wrong to me.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
thomas-neemann
Veteran
Posts: 11801
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: Bug or operator error in arch?

Post by thomas-neemann »

chrisb wrote: Sun May 08, 2022 5:26 pm It looks as if you didn't enter the second point and then it is created towards the current position of the mouse pointer. Doesn't look really wrong to me.
if i do the same steps with a line it works.
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Bug or operator error in arch?

Post by Roy_043 »

It's definitely a bug. The attached files hopefully fix the problem. Note that there is still an issue with the workflow. The length of the beam is not update as you enter the X coordinate, you have to do that manually.
Attachments
gui_snapper.py
(70.91 KiB) Downloaded 19 times
DraftGui.py
(103.21 KiB) Downloaded 19 times
User avatar
thomas-neemann
Veteran
Posts: 11801
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: Bug or operator error in arch?

Post by thomas-neemann »

Roy_043 wrote: Sun May 08, 2022 9:05 pm It's definitely a bug. The attached files hopefully fix the problem. Note that there is still an issue with the workflow. The length of the beam is not update as you enter the X coordinate, you have to do that manually.
Thank you very much, yes, I noticed that with the length elsewhere
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: (partially solved) Bug or operator error in arch?

Post by Roy_043 »

Attached a file with a Q&D (Quick and Dirty) fix for the length issue. The length of the beam in the task panel is not dynamically updated as you enter coordinates, but the correct length is used once you confirm the 2nd point of the beam.
Attachments
ArchStructure.py
(66.28 KiB) Downloaded 16 times
Last edited by Roy_043 on Mon May 09, 2022 10:22 am, edited 1 time in total.
User avatar
thomas-neemann
Veteran
Posts: 11801
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: (partially solved) Bug or operator error in arch?

Post by thomas-neemann »

Roy_043 wrote: Mon May 09, 2022 10:19 am Attached a file with a Q&D fix for the length issue. The length of the beam is not dynamically updated as you enter coordinates, but the correct length is used once you confirm the 2nd point of the beam.
Thanks very much. does q&d mean it won't be built into master?
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: (partially solved) Bug or operator error in arch?

Post by Roy_043 »

To me the current situation, feature freeze and waiting for the release of V0.20, is a sort of limbo. Fixing bugs is still allowed, but even then you are introducing new code that can potentially break things. So I am a bit hesitant to make PRs at the moment and the code we are dealing with here is a quite complex.

Regarding the Q&D edit of ArchStructure.py: There are many issues with the code, the edit should be seen as a temporary fix.
Post Reply