[PR Merged] Moving Windows/Doors
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 18
- Joined: Tue Feb 08, 2022 2:40 am
[PR Merged] Moving Windows/Doors
[Moderator : see post viewtopic.php?p=660136#p660136 on PR Merged]
Can someone explain why sometimes when I Draft/Arch/Bim Move a Window or Door it becomes disconnected from the opening in its Host wall? The attached file DoorInsertion002.FCStd demonstrates my problem. The door is currently not in the Wall opening, and moving it further along the Wall makes the situation worse. Try it.
The file was extracted from a larger project by copy and paste and for another reason that I don't understand the Line on which the Wall was built is now distant from the Wall. That is an aberration of the copy and paste as it is correctly positioned in the original. In any case it doesn't seem to have had any effect on the failure of the Wall opening to move in unison with the Door.
Thanks
Can someone explain why sometimes when I Draft/Arch/Bim Move a Window or Door it becomes disconnected from the opening in its Host wall? The attached file DoorInsertion002.FCStd demonstrates my problem. The door is currently not in the Wall opening, and moving it further along the Wall makes the situation worse. Try it.
The file was extracted from a larger project by copy and paste and for another reason that I don't understand the Line on which the Wall was built is now distant from the Wall. That is an aberration of the copy and paste as it is correctly positioned in the original. In any case it doesn't seem to have had any effect on the failure of the Wall opening to move in unison with the Door.
Thanks
- Attachments
-
- DoorInsertion002.FCStd
- (24.13 KiB) Downloaded 64 times
- thomas-neemann
- Veteran
- Posts: 11947
- Joined: Wed Jan 22, 2020 6:03 pm
- Location: Osnabrück DE 🇩🇪
- Contact:
Re: Moving Windows/Doors
in my opinion it is just as quick to delete a door and create a new one
- ragohix769
- Posts: 568
- Joined: Sat Jul 18, 2020 7:04 am
- Location: Rome - Italy
Re: Moving Windows/Doors
Ok, create always from scratch can do the job, but it's a workaround, because as you know moving Doors and Windows should work properly in a BIM WB, and not a nightmare like it is now.thomas-neemann wrote: ↑Thu Mar 10, 2022 2:50 pmin my opinion it is just as quick to delete a door and create a new one
After #ElonMuskBuyTwitter I'm no more on Twitter, that's really enough ![Sad :-(](./images/smilies/icon_e_sad.gif)
=> Now you can find me here on #Mastodon: https://mastodon.uno/@opensoul - I hope more people do the same![Smile :-)](./images/smilies/icon_e_smile.gif)
![Sad :-(](./images/smilies/icon_e_sad.gif)
=> Now you can find me here on #Mastodon: https://mastodon.uno/@opensoul - I hope more people do the same
![Smile :-)](./images/smilies/icon_e_smile.gif)
Re: Moving Windows/Doors
It seems there is a bug here ... (the opening go in opposite direction with the Wall object is rotated around Z-axis by 180 deg). Anyone like to fix this ?
Maybe people can suggest workflow in the meantime![Smile :)](./images/smilies/icon_e_smile.gif)
Say, build ArchWall based on DraftLine at correct position, do not move the Wall afterward.
Maybe people can suggest workflow in the meantime
![Smile :)](./images/smilies/icon_e_smile.gif)
Say, build ArchWall based on DraftLine at correct position, do not move the Wall afterward.
- Attachments
-
- DoorInsertion002_ r.FCStd
- (32.09 KiB) Downloaded 50 times
Re: Moving Windows/Doors
The workaround would then be to rotate the wall:
- Set the workingplane to "Top" with Draft_SelectPlane.
- Switch on Draft_Snap_Center and Draft_Snap_WorkingPlane.
- Change the "Move With Host" property of the door to false.
- Select the wall.
- Invoke Draft_Rotate.
- For the center of rotation pick the center of the top face of the wall.
- For the base angle pick a point with Shift held down to constrain to the X or Y axis.
- Release Shift.
- For the rotation angle pick a point on the opposite side of the center of rotation again with Shift held down.
- Change the "Move With Host" property of the door back to true.
-
- Posts: 18
- Joined: Tue Feb 08, 2022 2:40 am
Re: Moving Windows/Doors
Thank you all for your replies.
I acknowledge that many versions back the whole building of which this wall is just one small part was rotated through 180 degrees, and it would seem that this is the cause of the problem.
From a user perspective I submit that rotation is a pretty fundamental operation that shouldn't have unintended consequences.
Thank you Roy for your comprehensive step by step workaround. I have a whole building with many walls, some rotated (historically), some not and some containing many features. I hope that someone will take the necessary steps to fix this apparent bug as confused and frustrated users don't help the aspirations of the developers.
I acknowledge that many versions back the whole building of which this wall is just one small part was rotated through 180 degrees, and it would seem that this is the cause of the problem.
From a user perspective I submit that rotation is a pretty fundamental operation that shouldn't have unintended consequences.
Thank you Roy for your comprehensive step by step workaround. I have a whole building with many walls, some rotated (historically), some not and some containing many features. I hope that someone will take the necessary steps to fix this apparent bug as confused and frustrated users don't help the aspirations of the developers.
- thomas-neemann
- Veteran
- Posts: 11947
- Joined: Wed Jan 22, 2020 6:03 pm
- Location: Osnabrück DE 🇩🇪
- Contact:
Re: Moving Windows/Doors
yorik and all the arch programmers did a great job in my opinion. so as not to give the impression that freecad is half finished, i will say that freecad as it is now is very good for commercial use. you should be well trained and know freecad well, then "everything" is possible. easy and fast. I really enjoy working with it.
Re: Moving Windows/Doors
Trying to understand how the bug is created and digging through ArchWall.py, ArchComponent.py, ArchWindow.py.
starting from line 919 of ArchComponent.py
Not understand in ArchComponent.py why the object's attribute Placement seems would be changed by a method itself ...yorik wrote: ping
![Rolling Eyes :roll:](./images/smilies/icon_rolleyes.gif)
Code: Select all
if not self.isIdentity(placement):
obj.Placement = placement
else:
obj.Placement = p
Code: Select all
p = self.spread(obj,shape,placement).Placement.copy() # for some reason this gets zeroed in next line
obj.Shape = self.spread(obj,shape,placement)
if not self.isIdentity(placement):
obj.Placement = placement
else:
obj.Placement = p
else:
if allownosolid:
obj.Shape = self.spread(obj,shape,placement)
if not self.isIdentity(placement):
obj.Placement = placement
else:
FreeCAD.Console.PrintWarning(obj.Label + " " + translate("Arch","has no solid")+"\n")
else:
if allowinvalid:
obj.Shape = self.spread(obj,shape,placement)
if not self.isIdentity(placement):
obj.Placement = placement
Re: Moving Windows/Doors
hmm that seems weird indeed
i'll have a better look
![Smile :)](./images/smilies/icon_e_smile.gif)
Re: Moving Windows/Doors
I was experimenting with ArchComponent.py a month ago in relation to some other issues (structure, pipe, computeAreas). A project I have put on the side-burner for now (because it's quite complex in general). But my experimental version of the code does solve the OP's issue. I'll try to dissect the relevant bits later.
- Attachments
-
ArchComponent.py
- (95.37 KiB) Downloaded 48 times