[PR Merged] Moving Windows/Doors

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Test 08 - Church of The Light

Not much window punch holes. Model at discussion thread https://forum.freecadweb.org/viewtopic.php?f=24&t=44963
Screenshot from 2022-03-25 01-00-38.png
Screenshot from 2022-03-25 01-00-38.png (204.95 KiB) Viewed 1455 times
Screenshot from 2022-03-25 01-11-37.png
Screenshot from 2022-03-25 01-11-37.png (218.86 KiB) Viewed 1455 times
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: [PR] Re: Moving Windows/Doors

Post by paullee »

paullee wrote: Sat Mar 19, 2022 6:06 pm PR - https://github.com/FreeCAD/FreeCAD/pull/6617

(Not resolving the Arch Roof placement problem yet)
Better moment to test and merge this now ?

Thanks :)


Related discussion
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Moving Windows/Doors

Post by Roy_043 »

You may have to rebase... :mrgreen:
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Hmm... how to do it now ? :oops:


Anybody want to do more tests on your models ? :)
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Anyone can give some hint how to rebase the commit I have git push and make PR ?

Below is correct?

Code: Select all

(  git push origin previously, and made PR on github )

( now on my pc ? )

  git checkout master
  git fetch upstream
  git merge upstream/master
  git checkout ArchComponent_03_Fix-Placement-Multiplication_r
  git rebase master
  git push origin  
  
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Trying procedures as commented on github, not working :(

https://github.com/FreeCAD/FreeCAD/pull/6617
paullee
Veteran
Posts: 5097
Joined: Wed May 04, 2016 3:58 pm

[PR Merged] Re: Moving Windows/Doors

Post by paullee »

paullee wrote: Wed Sep 07, 2022 4:45 pm Trying procedures as commented on github, not working :(

https://github.com/FreeCAD/FreeCAD/pull/6617
OK, thanks to @Roy_043, PR is merged. Would more people help to test ? :)

@PheasantCoucal Please edit 1st post to include 'Fixed' if +ve.

Thanks.


git commit 1527793ce982a76acb6d17e92b8b4d117cd894d3
git commit 0ebd66ae2045f26cb9b76931f87efc0390dedfcf
Post Reply