[PR Merged] Moving Windows/Doors
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Moving Windows/Doors
OK, git fetch upstream and used the latest ArchComponent.py to add the 'fix'. Anyone can help to test again ?
Re: Moving Windows/Doors
Tested with the files discussed and seems all good. I am submitting a PR then.
Can you try and confirm it is fixed, and in the 1st post subject add [Fixed] pleasePheasantCoucal wrote: Ping
Thanks.
[PR] Re: Moving Windows/Doors
PR - https://github.com/FreeCAD/FreeCAD/pull/6617
https://github.com/FreeCAD/FreeCAD/pull/6608
(Not resolving the Arch Roof placement problem yet)
https://github.com/FreeCAD/FreeCAD/pull/6608
(Not resolving the Arch Roof placement problem yet)
Re: Moving Windows/Doors
Can anybody has previous models test the about revised ArchComponent.py would have impact on your model please ?
Yorik would like to defer the merge to after 0.20 fear that it might frustrate existing models.
Thanks
Re: Moving Windows/Doors
Test 01 - Villa Savoye Furniture, nothing wrong or relocated unusually, noted after recompute
Re: Moving Windows/Doors
Test 02 - Villa Savoye
Seem nothing relocated unexpectedly
Seem nothing relocated unexpectedly
Re: Moving Windows/Doors
The problem I can foresee would be that other people might have modeled with different strategies than you, where this inversion of placement multiplication could have an impact (basically the resulting placement is different) while on yours everything is fine. And we won't know until someone comes here saying "my model is broken". So I think it's safer if this happens not in a release but on a development cycle
Re: Moving Windows/Doors
Yes agree I hope this would solicit peoples to test their own models to verify if it would somehow break unexpectedly to our discussion here. Would wait to see.
Re: Moving Windows/Doors
Test 03 - OP's model
Re: Moving Windows/Doors
Test 04 - Regis' Elemental
Seems just a few window/door objects in the model...
Seems just a few window/door objects in the model...