Moving Windows/Doors

A forum dedicated to the Draft, Arch and BIM workbenches development.
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

OK, git fetch upstream and used the latest ArchComponent.py to add the 'fix'. Anyone can help to test again ? :)


ArchComponent.py
(97.33 KiB) Downloaded 14 times
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

paullee wrote: Thu Mar 17, 2022 2:27 pm OK, git fetch upstream and used the latest ArchComponent.py to add the 'fix'. Anyone can help to test again ? :)
ArchComponent.py
Tested with the files discussed and seems all good. I am submitting a PR then.
PheasantCoucal wrote: Ping
Can you try and confirm it is fixed, and in the 1st post subject add [Fixed] please :)

Thanks.
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

[PR] Re: Moving Windows/Doors

Post by paullee »

paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

paullee wrote: Thu Mar 17, 2022 2:27 pm OK, git fetch upstream and used the latest ArchComponent.py to add the 'fix'. Anyone can help to test again ? :)

ArchComponent.py
Can anybody has previous models test the about revised ArchComponent.py would have impact on your model please ?

Yorik would like to defer the merge to after 0.20 fear that it might frustrate existing models.

Thanks :)
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Test 01 - Villa Savoye Furniture, nothing wrong or relocated unusually, noted after recompute :)

Screenshot from 2022-03-22 01-54-48.png
Screenshot from 2022-03-22 01-54-48.png (316.61 KiB) Viewed 582 times
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Test 02 - Villa Savoye

Seem nothing relocated unexpectedly :)
Screenshot from 2022-03-22 02-13-03.png
Screenshot from 2022-03-22 02-13-03.png (304.13 KiB) Viewed 573 times
Screenshot from 2022-03-22 02-13-19.png
Screenshot from 2022-03-22 02-13-19.png (295.2 KiB) Viewed 573 times
Screenshot from 2022-03-22 02-15-30.png
Screenshot from 2022-03-22 02-15-30.png (265.21 KiB) Viewed 573 times
User avatar
yorik
Founder
Posts: 12866
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Moving Windows/Doors

Post by yorik »

The problem I can foresee would be that other people might have modeled with different strategies than you, where this inversion of placement multiplication could have an impact (basically the resulting placement is different) while on yours everything is fine. And we won't know until someone comes here saying "my model is broken". So I think it's safer if this happens not in a release but on a development cycle
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Yes agree :) I hope this would solicit peoples to test their own models to verify if it would somehow break unexpectedly to our discussion here. Would wait to see.
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Test 03 - OP's model
Screenshot from 2022-03-22 23-37-49.png
Screenshot from 2022-03-22 23-37-49.png (156.88 KiB) Viewed 451 times
paullee
Veteran
Posts: 4395
Joined: Wed May 04, 2016 3:58 pm

Re: Moving Windows/Doors

Post by paullee »

Test 04 - Regis' Elemental :)

Seems just a few window/door objects in the model...


Screenshot from 2022-03-22 23-55-40.png
Screenshot from 2022-03-22 23-55-40.png (319.37 KiB) Viewed 449 times
Screenshot from 2022-03-23 00-00-28.png
Screenshot from 2022-03-23 00-00-28.png (260.38 KiB) Viewed 449 times
Screenshot from 2022-03-22 23-58-59.png
Screenshot from 2022-03-22 23-58-59.png (249.32 KiB) Viewed 449 times
Post Reply