Draft 2d offset

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
ragohix769
Posts: 568
Joined: Sat Jul 18, 2020 7:04 am
Location: Rome - Italy

Re: Draft 2d offset

Post by ragohix769 »

thomas-neemann wrote: Mon Feb 07, 2022 12:40 pm
ragohix769 wrote: Mon Feb 07, 2022 12:34 pm
I don't understand Thomas. Maybe you mean "normal" Offset that without "2d"?
I mean this

1.png
Ah ok.
I was talking about (BIM_Offset2D) not that in Part, maybe it's another command.
Attachments
wepz.png
wepz.png (41.81 KiB) Viewed 899 times
After #ElonMuskBuyTwitter I'm no more on Twitter, that's really enough :-(
=> Now you can find me here on #Mastodon: https://mastodon.uno/@opensoul - I hope more people do the same :-)
User avatar
thomas-neemann
Veteran
Posts: 11921
Joined: Wed Jan 22, 2020 6:03 pm
Location: Osnabrück DE 🇩🇪
Contact:

Re: Draft 2d offset

Post by thomas-neemann »

here is an example (1 min) with part 3d offset

https://www.youtube.com/watch?v=T_YnIXAl-2U


phpBB [video]




OS: Ubuntu 20.04.1 LTS (XFCE/xubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 2022.111.28429 (Git) AppImage
Build type: Release
Branch: LinkStage3
Hash: ec814c42d02f15171f9dbb7f650400c9943abfe0
Python version: 3.9.9
Qt version: 5.12.9
Coin version: 4.0.1
OCC version: 7.5.3
Locale: German/Germany (de_DE)
Gruß Dipl.-Ing. (FH) Thomas Neemann

https://www.youtube.com/@thomasneemann5 ... ry=freecad
User avatar
ragohix769
Posts: 568
Joined: Sat Jul 18, 2020 7:04 am
Location: Rome - Italy

Re: Draft 2d offset

Post by ragohix769 »

thomas-neemann wrote: Mon Feb 07, 2022 2:28 pm here is an example (1 min) with part 3d offset

https://www.youtube.com/watch?v=T_YnIXAl-2U
Ok, so it's another command: Draft_Offset it's different then BIM_Offset2D.

I have problems with BIM_Offset2D, not the draft one. Maybe it's the wrong thread here, I'll open another one specific, sorry.
chrisb wrote: Sun Feb 06, 2022 10:26 pm
ragohix769 wrote: Sun Feb 06, 2022 10:04 pm Another problem that I have with Draft 2d offset: I select a wire or a sketch and when I use 2doffset, it automatically change the view to a nonsense or random position. I have to find the item then in the view. I don't know if this happen only to me, it's really annoying :-(
I cannot confirm this one.
You are right Chris, sorry: the problem that I have reported it's with BIM_Offset2D. Maybe I'll open a thred more specific.
Last edited by ragohix769 on Mon Feb 07, 2022 2:43 pm, edited 1 time in total.
After #ElonMuskBuyTwitter I'm no more on Twitter, that's really enough :-(
=> Now you can find me here on #Mastodon: https://mastodon.uno/@opensoul - I hope more people do the same :-)
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Draft 2d offset

Post by paullee »

Roy_043 wrote: Sun Feb 06, 2022 6:26 pm Draft_Offset does not handle sketches very well. See the attached file. Only the sketch in white (consistent direction and no arcs) is handled properly.
Yes, confirmed.

OS: Fedora 34 (Workstation Edition) (GNOME/gnome)
Word size of FreeCAD: 64-bit
Version: 0.20.27008 (Git)
Build type: Release
Branch: (HEAD detached at 9162733)
Hash: 91627338a44371fe9a8e815b4900f62558af98a1
Python version: 3.9.9
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.3
Locale: English/United States (en_US)


draft-offset-sketches_ r.FCStd
(16.47 KiB) Downloaded 11 times
Screenshot from 2022-02-07 22-54-06.png
Screenshot from 2022-02-07 22-54-06.png (191.77 KiB) Viewed 863 times
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Draft 2d offset

Post by paullee »

Similar results :-

OS: Fedora 34 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.19.2)
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.8.8
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: Draft 2d offset

Post by paullee »

0.18 AppImage no longer run correctly on my Fedora 14, so can't test if it had worked previously.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Draft 2d offset

Post by Roy_043 »

Roy_043 wrote: Fri Feb 04, 2022 2:06 pm https://github.com/FreeCAD/FreeCAD/pull/5496

Edit:
Oops, it's not that simple. Will have to do some more checks. :mrgreen:
I have update the PR. The connect function in intersections.py did not work properly if no intersection was found between the 1st segment and the last segment. It would then use the undefined v2 value to create a line segment. The problem would only occur if closed=True. I have also refactored the function.

This will fix the issue in the OP, but not the other issues reported in this thread.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Draft 2d offset

Post by Roy_043 »

PR has been merged.
Post Reply