Arch Wall - Block Count (Count Entire & Count Broken)

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Arch Wall - Block Count (Count Entire & Count Broken)

Post by Palmtree »

Is Arch Wall - Block Count Accurate?
(Count Entire & Count Broken - https://wiki.freecadweb.org/Arch_Wall)
Is it still in development not yet completed?

I am trying to drill down into the details of FC for better understanding. I created a test two walls (refer to attached). Both simple and modular (block size 390×190mm and 10mm Joint). I counted the block (calculation attached).

Woops! No match between my calculated numbers and the Arch Wall - Block Count!
Why? Any comment please?

OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/Australia (en_AU)
Attachments
3-Brick WallR3.FCStd
(61.45 KiB) Downloaded 36 times
New Bitmap Image.jpg
New Bitmap Image.jpg (377.27 KiB) Viewed 2141 times
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Roy_043 »

I have found the cause of the bug. The first block in each row has a length of BlockLength+Joint. And the code considers any block that does not have the standard measurements as 'Broken'. I am attaching the file with the fix and I'll do a PR.
Attachments
ArchWall.py
(79.91 KiB) Downloaded 33 times
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Palmtree »

Roy_043 wrote: Wed Jul 07, 2021 4:31 pm I have found the cause of the bug. The first block in each row has a length of BlockLength+Joint. And the code considers any block that does not have the standard measurements as 'Broken'. I am attaching the file with the fix and I'll do a PR.

Many Thanks Roy_043
:D :D :D :D :D :D
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Palmtree »

Hi Roy_043 and the FC’s Community

LinkDaily (Version attached below ) has implemented this thread’s PR (https://github.com/FreeCAD/FreeCAD/pull/4910)
Thanks.

The Latest FC “FreeCAD_weekly-builds-29126-2022-06-12-conda-Windows-x86_64-py38.7z” has not yet approved and merged it.

Any comment please?

*****************************
*****************************
OS: Windows 10 (10.0)
Word size of FreeCAD: 64-bit
Version: 2022.430.26244 +4758 (Git)
Build type: Release
Branch: LinkDaily
Hash: b024b876480a533018fdc702145e9e38f8c54ba6
Python version: 3.9.12
Qt version: 5.12.9
Coin version: 4.0.1
OCC version: 7.5.3
Locale: English/Australia (en_AU)

*****************************
*****************************
OS: Windows 10 (10.0)
Word size of FreeCAD: 64-bit
Version: 0.20.29126 (Git)
Build type: Release
Branch: master
Hash: 6c1c63cffebe6a9d55bd9b1d8ca6b741a4d16548
Python 3.8.13, Qt 5.12.9, Coin 4.0.0, Vtk 9.1.0, OCC 7.5.3
Locale: English/Australia (en_AU)
Installed mods:
* ArchTextures
* Behave-Dark-Colors 0.0.1
* BIM 2021.12.0
* Curves 0.4.4
* dodo
* fasteners 0.3.43
* FreeCAD_SketchArch-master
* Glass
* PieMenu
* pivy_trackers
* ProDarkThemePreferencePack 1.0.0
* Reinforcement
* Trails 2022.1.0
Attachments
2.jpg
2.jpg (266.08 KiB) Viewed 1240 times
1.jpg
1.jpg (266.25 KiB) Viewed 1240 times
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Roy_043 »

AFAICT the PR has been merged in master as well:
https://github.com/FreeCAD/FreeCAD/blob ... ll.py#L873

Some other piece of code has perhaps caused the regression. Will try to have a look later.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Roy_043 »

I can't reproduce. See attached file. Please post your file.

Code: Select all

OS: Windows 8.1 (6.3)
Word size of FreeCAD: 64-bit
Version: 0.20.29126 (Git)
Build type: Release
Branch: master
Hash: 6c1c63cffebe6a9d55bd9b1d8ca6b741a4d16548
Python 3.8.13, Qt 5.12.9, Coin 4.0.0, Vtk 9.1.0, OCC 7.5.3
Locale: Dutch/Netherlands (nl_NL)
Installed mods: 
Attachments
wall-block-count.FCStd
(11.49 KiB) Downloaded 17 times
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Palmtree »

Hi Roy_043

I have reattached the file (Also it is attached to the 1st part of this tread, refer to the top).
Thank for your quick response
Cheers
Attachments
3-Brick WallR3.FCStd
(61.45 KiB) Downloaded 16 times
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Roy_043 »

Ah, the same file, I missed that.
Again I can't confirm.

Please verify that your ArchWall.py is correct. See attached.
If that does not help try renaming your user.cfg file.
Attachments
ArchWall.py
(79.8 KiB) Downloaded 20 times
User avatar
Palmtree
Posts: 104
Joined: Wed Apr 08, 2020 5:06 am

Re: Arch Wall - Block Count (Count Entire & Count Broken)

Post by Palmtree »

Roy_043 wrote: Mon Jun 13, 2022 11:13 am Ah, the same file, I missed that.
Again I can't confirm.

Please verify that your ArchWall.py is correct. See attached.
If that does not help try renaming your user.cfg file.
I tried the following with no luck:

1- Download your file "ArchWall.py" and past it over to replace my file at (... \FreeCAD_weekly-builds-29126-2022-06-12-conda-Windows-x86_64-py38\Mod\Arch)
2- delete all *.cfg files including all folder at C:\Users\User\AppData\Roaming\FreeCAD
And Install a fresh copy of FreeCAD_weekly-builds-29126-2022-06-12-conda-Windows-x86_64-py38

Can any one on the forum with the following setting (similar to my setting) confirm/check the brick count reported above.
********************
OS: Windows 10 (10.0)
Word size of FreeCAD: 64-bit
Version: 0.20.29126 (Git)
Build type: Release
Branch: master
Hash: 6c1c63cffebe6a9d55bd9b1d8ca6b741a4d16548
Python 3.8.13, Qt 5.12.9, Coin 4.0.0, Vtk 9.1.0, OCC 7.5.3
Post Reply