GuiUp check in viewprovider code: why?

Need help, or want to share a macro? Post here!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

GuiUp check in viewprovider code: why?

Post by Roy_043 »

In the viewprovider code of Draft objects you can find:

Code: Select all

if App.GuiUp:
    from pivy import coin
    import FreeCADGui as Gui
    import Draft_rc
    # The module is used to prevent complaints from code checkers (flake8)
    bool(Draft_rc.__name__)
Why the GuiUp check? Can viewproviders be loaded if the GUI is not available?
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: GuiUp check in viewprovider code: why?

Post by Kunda1 »

I believe this was vocx's approach to make Draft future friendly if it was to be run headless.

reference: https://forum.freecadweb.org/viewtopic.php?f=10&t=44101
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: GuiUp check in viewprovider code: why?

Post by Roy_043 »

Thanks for the link. It is related, but not quite what I mean. AFAIK viewproviders are not loaded if the GUI is not available, so the GuiUp check, in view_base.py for example, seems superfluous.

Link to the code:
https://github.com/FreeCAD/FreeCAD/blob ... py#L40-L45
Post Reply