Page 1 of 12
IconThemes
Posted: Mon Oct 10, 2016 1:29 pm
by triplus
- IconThemes.png (19.85 KiB) Viewed 7249 times
Objective: Improve current icon themes support in FreeCAD.
Code repository:
https://github.com/triplus/IconThemes
Reference:
viewtopic.php?f=10&t=13180
Re: IconThemes
Posted: Mon Oct 10, 2016 1:47 pm
by pablogil
Looking forward to updates or public releases
Re: IconThemes
Posted: Mon Oct 10, 2016 2:24 pm
by triplus
I already shared some observations here:
viewtopic.php?f=10&t=13180&start=50#p140663
For now IconThemes module main focus will be to provide support for FreeCAD commands. This i guess can be achieved in rather straightforward way (but it needs to be tested on all supported platforms first for the final confirmation). There are some exceptions for now like Draft Snap commands and workbench icons. As for other icons (tree view, sidebar icons...). Support for such icons likely won't work until corresponding icons will have standard Qt icon theme support or some other approach will be used.
As for releasing the code. I have implemented all planned functionalities and i need to clean up the code first for after to share the work done. This likely will happen in 2 steps. Step 1 providing basic functionality to start using the module. Step 2 add a tool or two for icon designer to get the needed information (like what icon file name needs to be set for corresponding command).
Re: IconThemes
Posted: Mon Oct 10, 2016 9:00 pm
by pablogil
Both points are very interesting
Re: IconThemes
Posted: Wed Oct 12, 2016 9:14 am
by nvd
Looking forward.
Re: IconThemes
Posted: Mon Oct 17, 2016 12:41 pm
by triplus
Hi @pablogil.
I will provide demo icon pack on my repository containing this 7 icons:
viewtopic.php?f=10&t=13180&start=30#p135317
I feel that proper attribution needs to be given therefore i am guessing the same copyright information and licence as you used for stylesheets should do?
Re: IconThemes
Posted: Mon Oct 17, 2016 12:59 pm
by pablogil
triplus wrote:Hi @pablogil.
I will provide demo icon pack on my repository containing this 7 icons:
viewtopic.php?f=10&t=13180&start=30#p135317
I feel that proper attribution needs to be given therefore i am guessing the same copyright information and licence as you used for stylesheets should do?
Your guessing is right
Re: IconThemes
Posted: Mon Oct 17, 2016 9:39 pm
by triplus
First release of IconThemes
- Ability to restore default set of icons
- Apply icons only if not already applied
- List of available icon themes
- Icon preview area
- Accessories menu entry (Tools menu)
- DemoTheme(icon artwork by pablogil)
- Run as single instance
UseCase
IconThemes module needs to be installed (or used as macro) and DemoTheme icon theme should be extracted into an appropriate location. Detailed instructions on how to achieve that are available on GitHub:
https://github.com/triplus/IconThemes
- AccessoriesMenu.png (33.27 KiB) Viewed 7004 times
New Accessories entry can be found under the Tools menu.
- Preferences.png (29.81 KiB) Viewed 7004 times
Selecting the IconThemes option should show IconThemes preferences.
- DefaultTheme.png (16.74 KiB) Viewed 7004 times
The default icon theme.
- DemoTheme.png (12.82 KiB) Viewed 7004 times
And the DemoTheme icon theme applied.
Re: IconThemes
Posted: Tue Oct 18, 2016 9:20 am
by pablogil
So, so, so cool!
It's working like a charm!
I'll start playing around with a full custom iconTheme on my spare time =)
Some questions:
- you have used the 48x48 pixel svg icons for any special reason? I guess as being vector icons it doesn't matter but I would have chosen the 64x64 ones...
- have you find any limitation with workbenches, special icons or so?
- how could I easily find the names I should apply to svg files?
Thank you!
Re: IconThemes
Posted: Tue Oct 18, 2016 1:46 pm
by triplus
pablogil wrote:So, so, so cool!
It's working like a charm!
I'll start playing around with a full custom iconTheme on my spare time =)
Good to hear that.
you have used the 48x48 pixel svg icons for any special reason? I guess as being vector icons it doesn't matter but I would have chosen the 64x64 ones...
In the DemoTheme pack? I used 48x48 size as that was the biggest size you made. Or in the icon preview area? There i just used the grid size that makes sense. Making 64x64 size icons for icon theme purposes therefore doesn't represent any issue.
have you find any limitation with workbenches, special icons or so?
Not much beyond what i documented above.
how could I easily find the names I should apply to svg files?
Give it a week.
Thank you!
You're welcome.