0.20 bug/regression Array Pattern issue #6641

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: 0.20 bug/regression Array Pattern

Post by jnxd »

user1234 wrote: Fri Mar 25, 2022 6:07 am
jnxd wrote: Fri Mar 25, 2022 5:49 am So presumably this was working right before git commit 03da9d3501?
Yes, exactly. I checked out one commit before.
git commit 89b8e81d5c3b11572a0288720d0b4145d2ec2a7e
Interesting. Just reverting that one commit however gives some very bad result
Screenshot from 2022-03-25 17-40-15.png
Screenshot from 2022-03-25 17-40-15.png (21.27 KiB) Viewed 1809 times
I wonder if this is the only culprit then...
My latest (or last) project: B-spline Construction Project.
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: 0.20 bug/regression Array Pattern

Post by jnxd »

user1234 wrote: Fri Mar 25, 2022 6:07 am But also i compiled this branch with OCCT7.4.0, because it does not work with OCCT7.6.1, since some newer OCCT adapt commits are not in this branch. Maybe with a newer OCCT it works.
I can confirm the bug happens with 7.5.3. Can we try going backwards: trying the branch with 7.4.0?
My latest (or last) project: B-spline Construction Project.
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: 0.20 bug/regression Array Pattern

Post by user1234 »

jnxd wrote: Fri Mar 25, 2022 9:42 pm Just reverting that one commit however gives some very bad result
I also got a similar error, but i only forgot to recompile FreeCAD with the atm installed version.

I think also this issue #6584 regression have the same source, arrays and a little bit refining. I will try some tests .....

Greetings
user1234
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: 0.20 bug/regression Array Pattern

Post by user1234 »

jnxd wrote: Sat Mar 26, 2022 12:13 am Can we try going backwards: trying the branch with 7.4.0?

I am atm on 7.4.0. But i do not think that this is an issue.

But funny story: i had some issue while recompiling with the fresh master today. So i made a make clean and the result looks different then the days before. The fillet works now with the pattern (the segments are still here).

0.png
0.png (51.49 KiB) Viewed 1606 times


Greetings
user1234
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: 0.20 bug/regression Array Pattern

Post by jnxd »

user1234 wrote: Sat Mar 26, 2022 7:00 pm I am atm on 7.4.0. But i do not think that this is an issue.
user1234 wrote: Sat Mar 26, 2022 7:00 pm
Interesting. Thanks for updating.
But funny story: i had some issue while recompiling with the fresh master today. So i made a make clean and the result looks different then the days before. The fillet works now with the pattern (the segments are still here).
So is this now working with 7.4.0 or newer version?
My latest (or last) project: B-spline Construction Project.
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: 0.20 bug/regression Array Pattern

Post by user1234 »

jnxd wrote: Sat Mar 26, 2022 7:14 pm So is this now working with 7.4.0 or newer version?

7.4.0 only atm. But dumb i, i forgot, that your changes are not implemented in the master.

Greetings
user1234
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: 0.20 bug/regression Array Pattern

Post by jnxd »

user1234 wrote: Sat Mar 26, 2022 7:18 pm 7.4.0 only atm. But dumb i, i forgot, that your changes are not implemented in the master.
That explains why the rib itself is not there. I just rebased if you want to test.
My latest (or last) project: B-spline Construction Project.
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: 0.20 bug/regression Array Pattern

Post by user1234 »

jnxd wrote: Sat Mar 26, 2022 8:01 pm I just rebased if you want to test.

I know, it ws just a remark, that my note before was invalid.


Generally now i know a little bit more. The issue seems the PartDesign Sweep. When i remade the model with Part, i never get the issue, all setting throuht. But when i make i clone ony of the sweep and remade the rest in Part, the issue raises. On OCCT7.4. and 7.6.1.


Part_Sweep_Array.png
Part_Sweep_Array.png (206.48 KiB) Viewed 1462 times

PartDesign_Sweep_Array.png
PartDesign_Sweep_Array.png (176.9 KiB) Viewed 1462 times

Sweep_Array_Bug.FCStd
(127.32 KiB) Downloaded 26 times

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.20.28440 (Git)
Build type: Release
Branch: master
Hash: 63636c8082e44bc66f9af70c221fbff5dcd46f5e
Python 3.9.2, Qt 5.15.2, Coin 4.0.0, OCC 7.4.0
Locale: C/Default (C)

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.20.28440 (Git)
Build type: Release
Branch: master
Hash: 63636c8082e44bc66f9af70c221fbff5dcd46f5e
Python 3.9.2, Qt 5.15.2, Coin 4.0.0, OCC 7.6.1
Locale: C/Default (C)

Greetings
user1234
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: 0.20 bug/regression Array Pattern

Post by jnxd »

user1234 wrote: Sat Mar 26, 2022 9:39 pm The issue seems the PartDesign Sweep.
The issue is still within Transform. The problem is that with changing to CompSolids, some of the fuse/cut shapes are still Compounds, which OCC treats as "more complicated" (since a compound can contain loose faces etc. but I suppose CompSolids cannot). So this addition is causing an issue.

I figured that out a couple hours ago but I'm still figuring how to solve this.
My latest (or last) project: B-spline Construction Project.
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: 0.20 bug/regression Array Pattern

Post by user1234 »

jnxd wrote: Sun Mar 27, 2022 1:01 am
since a compound can contain loose faces etc. but I suppose CompSolids cannot

As far as i know, this is true, as long the geometry is not invalid.



jnxd wrote: Sun Mar 27, 2022 1:01 am
The issue is still within Transform.

Just saying, when i transform the PartDesign Sweep per hand, it also not work. In contrast when i transform a Part Sweep, it works. But this is just my observation i made.


Greeetings
user1234
Post Reply