paddle wrote: ↑Fri Mar 11, 2022 9:42 pm
For rotate scale and offset this could be useful for preview on mouse move.
This is not even difficult to do (you certainly have the capabilities to do it).
Internally the edit curve is just a vector of 2d coordinates and an index indicating where separate lines start and end. In the function I indicated there is a single index so it is a sequence of line segments through the coordinates.
There are two ways of doing this:
1. Extending the DrawEdit to a std::vector<std::vector<Base::Vector2d>>.
2. Creating a new overload taking a std::vector<Part::Geometry *>.
Way 1
What needs to be done is:
1. Create another function with the same signature, except that it takes a std::vector<std::vector<Base::Vector2d>>.
2. Make the functionality of converting to coin more generic, so that different indices are created for different curves (ideally one function calls the other).
3. Change all the code used for calling either of these two functions so that it takes a template parameter (so that it can take either). This will enable a leaner interface (in ViewProviderSketch and the attorney).
Then if you call it with a std::vector<Base::Vector2D>, the first function is called. If you call it with a std::vector<std::vector<Base::Vector2d>>, the second function is called. You get as many curves as you want drawn in edit mode.
This is easy. It has the advantage that you can draw random curves (even when you do not have an equivalent Part::Geometry). It has the disadvantage that you need to teach DrawSketchHandler how to draw Part::Geometry, which is not difficult nonetheless:
https://github.com/FreeCAD/FreeCAD/blob ... r.cpp#L301
and incurs in some code duplication.
Way 2
You make an overload to that function that takes a std::vector<Part::Geometry *>. Then you try to leverage EditModeCoinGeometryConverter so that fills in your geometry (reusing the same drawing code it uses for the ViewProvider geometry).
This one is neater if you are drawing existing Part::Geometry. It may need some modification to EditModeCoinGeometryConverter. It is not much of an advantage if you do not actually have the Part::Geometry created or want to draw something different from Part::Geometries.
paddle wrote: ↑Fri Mar 11, 2022 9:42 pm
Currently what I'm doing is that I open a command on activate.
Then in mouse move it does :
Abort command
Create new command
Create géométries by docommand.
Redraw.
Then the command is commit only on release button.
I think you'll probably not like this idea very much.
Also it seems rather CPU intensive. For rotate for instance if you make something like 50 copies of a slot it starts to be quite slow.
It sounds like some prototype code to test a concept that needs to be redone when the concept is proven
.
When code feels bad, it is generally bad. Aborting conveys the intention that I wanted to do something and I cannot do it anymore. It does not convey the intention that I did not know upfront that what I was doing is not what I want and I did it nevertheless, just for representation purposes.
You do not want to create a command. You do not want to insert geometry in the sketch. You just want to draw. If the current capability to draw is not enough, then just improve it. Improving things does feel so right...
paddle wrote: ↑Fri Mar 11, 2022 9:42 pm
But that's for later I guess. For now we can focus on tool settings.
I am in my little pre-release loop, so any bug/PR relating to bugs/issues with PRs merged or to be merged before release takes priority. This has taken most the scarce time I could dedicate to FreeCAD this week. Then, next in the list is your tool widget.