Allow use of circle edge to select axis in Revolution/Groove and Helix
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Allow use of circle edge to select axis in Revolution/Groove and Helix
PR for Revolution/Groove and Helix: https://github.com/FreeCAD/FreeCAD/pull/4451
PR for PolarPattern: https://github.com/FreeCAD/FreeCAD/pull/4469
Demo:
Demo, polar pattern:
Edit: Added a second PR for the Polar pattern version
PR for PolarPattern: https://github.com/FreeCAD/FreeCAD/pull/4469
Demo:
Demo, polar pattern:
Edit: Added a second PR for the Polar pattern version
Last edited by davidosterberg on Tue Feb 16, 2021 6:01 pm, edited 1 time in total.
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
Sweet !
I like it - a lot
I like it - a lot
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
Aha, very nice. Took a long time for my slow brain after watching the excellent demo to finally put together that the cylinder is not on the Z axis.
Now makes good sense. Thanks.
Now makes good sense. Thanks.
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
I added the same functionality to the PartDesign Polar pattern. See OP for demo. Do you think I should add this to Draft array as well? It is curious to me how non-parametric that feature is. So maybe some people want it like that? I think it could be useful for adding bolts around a circular bolt flange for example.
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
If you busy with PD
I can think of another situation what at least i'm missing. The possibility to add an axis in an sketch that can be used as axis reference (basically for it's own revolve / groove.
I can think of another situation what at least i'm missing. The possibility to add an axis in an sketch that can be used as axis reference (basically for it's own revolve / groove.
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
If I understand you correctly. This is already supported in both Helix and Revolve/Groove. Just add a construction line, and it will appear in the Axis selection box.
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
stupid i never tried that... probably because a construction line is at least to me lower level hierarchy than (normal geometry or )axis.
that makes the implementation of a real axis feature in sketch more difficult (at least on major release that support both)
that makes the implementation of a real axis feature in sketch more difficult (at least on major release that support both)
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
It is because the sketch based features in part design need a closed contour in order to do their thing. If the axis was not a construction line it would break that. Anyway, a construction line is appropriate, because the helix axis / groove axis, etc are mathematical constructions, not physical features of the model.Jee-Bee wrote: ↑Wed Feb 17, 2021 7:49 am stupid i never tried that... probably because a construction line is at least to me lower level hierarchy than (normal geometry or )axis.
that makes the implementation of a real axis feature in sketch more difficult (at least on major release that support both)
Re: Allow use of circle edge to select axis in Revolution/Groove and Helix
Thank you so much for this great enhancement!davidosterberg wrote: ↑Tue Feb 16, 2021 6:04 pm I added the same functionality to the PartDesign Polar pattern.
Definitly, +1Do you think I should add this to Draft array as well?