Allow use of circle edge to select axis in Revolution/Groove and Helix

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by davidosterberg »

PR for Revolution/Groove and Helix: https://github.com/FreeCAD/FreeCAD/pull/4451
PR for PolarPattern: https://github.com/FreeCAD/FreeCAD/pull/4469

Demo:
pd_circle_selection_mode.gif
pd_circle_selection_mode.gif (244.06 KiB) Viewed 1941 times

Demo, polar pattern:
circle_reference.gif
circle_reference.gif (282.81 KiB) Viewed 1716 times

Edit: Added a second PR for the Polar pattern version
Last edited by davidosterberg on Tue Feb 16, 2021 6:01 pm, edited 1 time in total.
LHC
Posts: 321
Joined: Thu Sep 17, 2020 4:21 pm
Location: Canadian Coffee Shop

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by LHC »

Sweet !

I like it - a lot :D
chrisb
Veteran
Posts: 53919
Joined: Tue Mar 17, 2015 9:14 am

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by chrisb »

:+1:
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
mendy
Posts: 262
Joined: Mon May 21, 2018 2:16 pm

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by mendy »

Aha, very nice. Took a long time for my slow brain after watching the excellent demo to finally put together that the cylinder is not on the Z axis.
Now makes good sense. Thanks.
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by davidosterberg »

I added the same functionality to the PartDesign Polar pattern. See OP for demo. Do you think I should add this to Draft array as well? It is curious to me how non-parametric that feature is. So maybe some people want it like that? I think it could be useful for adding bolts around a circular bolt flange for example.
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by Jee-Bee »

If you busy with PD
I can think of another situation what at least i'm missing. The possibility to add an axis in an sketch that can be used as axis reference (basically for it's own revolve / groove.
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by davidosterberg »

Jee-Bee wrote: Tue Feb 16, 2021 9:22 pm If you busy with PD
I can think of another situation what at least i'm missing. The possibility to add an axis in an sketch that can be used as axis reference (basically for it's own revolve / groove.
If I understand you correctly. This is already supported in both Helix and Revolve/Groove. Just add a construction line, and it will appear in the Axis selection box.
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by Jee-Bee »

stupid i never tried that... probably because a construction line is at least to me lower level hierarchy than (normal geometry or )axis.
that makes the implementation of a real axis feature in sketch more difficult (at least on major release that support both)
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by davidosterberg »

Jee-Bee wrote: Wed Feb 17, 2021 7:49 am stupid i never tried that... probably because a construction line is at least to me lower level hierarchy than (normal geometry or )axis.
that makes the implementation of a real axis feature in sketch more difficult (at least on major release that support both)
It is because the sketch based features in part design need a closed contour in order to do their thing. If the axis was not a construction line it would break that. Anyway, a construction line is appropriate, because the helix axis / groove axis, etc are mathematical constructions, not physical features of the model.
User avatar
-alex-
Veteran
Posts: 1853
Joined: Wed Feb 13, 2019 9:42 pm
Location: France

Re: Allow use of circle edge to select axis in Revolution/Groove and Helix

Post by -alex- »

davidosterberg wrote: Tue Feb 16, 2021 6:04 pm I added the same functionality to the PartDesign Polar pattern.
Thank you so much for this great enhancement!
Do you think I should add this to Draft array as well?
Definitly, +1
Post Reply