[FIXED] FC#3006: PartDesign Mirrored bugs

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: FC#3006: PartDesign Mirrored bugs

Post by DeepSOIC »

kkremitzki wrote: Thu Jun 01, 2017 5:34 am First question:
what's up with this inversion? https://github.com/FreeCAD/FreeCAD/blob ... pp#L74-L77
I don't know, but for me, mirroring seems to get the expected result for "Horizontal sketch axis" and "Vertical sketch axis", when the sketch is on XY plane at least. All other options give correct results too, except for mirroring against XY plane, which gives this:
pd mirrored.png
pd mirrored.png (401.32 KiB) Viewed 2405 times
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11018 (Git) <---- rather old already :shock: 200 commits behind
Build type: Release
Branch: master
Hash: 0ad2e47f4d611a22f679e5b3ef5ed6851f8a02be
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: FC#3006: PartDesign Mirrored bugs

Post by DeepSOIC »

And now I have rotated the sketch about (1,1,1) axis, and mirroring works perfectly for all choices.
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: FC#3006: PartDesign Mirrored bugs

Post by DeepSOIC »

So my opinion on the problem. I think we likely have two bugs:
1. bug with placement of ghost shape, when intersection is not detected. Execute() is likely working correctly.
2. bug with intersection detection, which may be failing to detect "touch" intersections, but works with "penetrate" intersections.
User avatar
kkremitzki
Veteran
Posts: 2509
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: FC#3006: PartDesign Mirrored bugs

Post by kkremitzki »

DeepSOIC wrote: Thu Jun 01, 2017 10:15 pm So my opinion on the problem. I think we likely have two bugs:
1. bug with placement of ghost shape, when intersection is not detected. Execute() is likely working correctly.
2. bug with intersection detection, which may be failing to detect "touch" intersections, but works with "penetrate" intersections.
Yup, Abdullah and I came to this conclusion as well and divided up the investigation, with me taking the first and him taking the second.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: FC#3006: PartDesign Mirrored bugs

Post by DeepSOIC »

Cooperation :D cool!!
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: FC#3006: PartDesign Mirrored bugs

Post by abdullah »

DeepSOIC wrote: Thu Jun 01, 2017 10:37 pm Cooperation :D cool!!
Very glad to see you around :D :D :D :D

I have documented the full bug problem here:
https://www.freecadweb.org/tracker/view.php?id=3065

This should enable everybody who want to test to have reproducible results and support the decision making process.

I am giving it a chance to both the Extrema method and the "deprecated" boolean method under it:
https://forum.freecadweb.org/viewtopic. ... ion#p41049

Tomorrow is another day...:)
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: FC#3006: PartDesign Mirrored bugs

Post by abdullah »

DeepSOIC wrote: Thu Jun 01, 2017 10:37 pm Cooperation :D cool!!
BTW, some of the action went here:
https://gitter.im/FreeCAD/FreeCAD
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: FC#3006: PartDesign Mirrored bugs

Post by DeepSOIC »

abdullah wrote: Thu Jun 01, 2017 11:24 pm BTW, some of the action went here: https://gitter.im/FreeCAD/FreeCAD
Unfortunately, I am unlikely to keep up with both forum and generic freecad gitter.

I've set up a gitter room for toponaming with jnxd, maybe it is worth having a gitter room for partdesign as well.
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: FC#3006: PartDesign Mirrored bugs

Post by abdullah »

DeepSOIC wrote: Thu Jun 01, 2017 11:28 pm
abdullah wrote: Thu Jun 01, 2017 11:24 pm BTW, some of the action went here: https://gitter.im/FreeCAD/FreeCAD
Unfortunately, I am unlikely to keep up with both forum and generic freecad gitter.

I've set up a gitter room for toponaming with jnxd, maybe it is worth having a gitter room for partdesign as well.
I have realised that forum and Gitter tend to suck more time. If I were to choose, forum is for sure the choice. However, Gitter is nice for real-time collaboration. I would not tend to discuss interesting topics out of the forum, because then we will be missing information in later searches in posts. However, just to yesterday notify Kurt of my findings to see how it was solving his issues, that went rather fast...
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: FC#3006: PartDesign Mirrored bugs

Post by abdullah »

I have doubts about what is the intended result of a multi-transformation and I have posted a question here with an example:

https://forum.freecadweb.org/viewtopic. ... 65#p176663

Which one do you think is the correct behaviour, i.e. how the tool should work? A or B?
Post Reply