FreeCAD Forum

I can't build - have an issue with shiboken2 library.

I think the error is easy to fix by renaming method "calculate_principal_stress" to "calculate_principal_stress_reinforced" everywhere (3 locations) in resulttools.py. That or change the test to call calculate_principal_stress instead. Not elegant, but it should work. See attached:


Sorry, I can't do any better at the moment. I did not know today was the deadline for FC20 release ... pure coincidence.

Perhaps better to roll back to earlier commit and leave this fix for the next version.

I can't run all the tests required.

I had to revert the second PR. Only the removal of the 3 stresses are now in.

The release was made. so everything further in the next release cycle.

Please then just make PRs by yourself. This way the CI will run the tests for us that such trouble won't happen again.

thanks and regards
Uwe

Great, thanks Uwe.

HarryvL wrote: ↑Mon Jun 13, 2022 2:26 pm 1) I moved the three stresses up to the vector section, because that’s what they are and that’s what you need to display them in ParaView.

I had to revert your removal of the principal stresses because they caused a regression:
- for "normal" mechanical analyses one needs these 3 principal stresses.

It was my mistake to merge this, because when you look at the links in the comments above the definition of the stresses:
git commit 3af54a7dda
you see that we need to distinguish here:
- if reinforced material -> we get PS1Vector etc. but also the principal stress scalars
- otherwise only the scalars

So maybe just a renaming should fix your issue. Here is a PR that does this:
https://github.com/FreeCAD/FreeCAD/pull/7246

Please give it a try and report back.

uwestoehr wrote: ↑Sun Jul 24, 2022 3:46 am Please give it a try and report back.

I am not good at github, so manually typed your proposed modifications, compiled and tested this:


The Principal Stress Vectors are transferred properly to ParaView and can be used in the relevant filters.

Thanks for solving this issue and apologies for the late response.

@HarryvL here's a trick:

• In your browser, go to the PR or git commit that you're trying to test (lets say it's https://github.com/FreeCAD/FreeCAD/pull/7246)
• Append .diff to the end of the URL. Eg https://github.com/FreeCAD/FreeCAD/pull/7246.diff returns a raw diff ---> https://patch-diff.githubusercontent.co ... /7246.diff
• Go to the top level of your FreeCAD source directory
• Type

  Code: Select all

  curl https://patch-diff.githubusercontent.com/raw/FreeCAD/FreeCAD/pull/7246.diff | git apply -v

• Result: if the patch applies cleanly, you've just successfully patched the code

Thanks I didn't know that too.

Kunda1 wrote: ↑Sat Aug 20, 2022 5:46 pm @HarryvL here's a trick:

• In your browser, go to the PR or git commit that you're trying to test (lets say it's https://github.com/FreeCAD/FreeCAD/pull/7246)
• Append .diff to the end of the URL. Eg https://github.com/FreeCAD/FreeCAD/pull/7246.diff returns a raw diff ---> https://patch-diff.githubusercontent.co ... /7246.diff
• Go to the top level of your FreeCAD source directory
• Type

  Code: Select all

  curl https://patch-diff.githubusercontent.com/raw/FreeCAD/FreeCAD/pull/7246.diff | git apply -v

• Result: if the patch applies cleanly, you've just successfully patched the code

Thanks !

HarryvL wrote: ↑Sat Aug 20, 2022 2:05 pm The Principal Stress Vectors are transferred properly to ParaView and can be used in the relevant filters.

Thanks for solving this issue and apologies for the late response.

Thanks. I merged the PR now and will backport this to FreeCAD 0.20.x later.