Are you sure you captured all the changes? See above exchange.
Principal Stress Plots
Moderator: bernd
Forum rules
and Helpful information for the FEM forum
and Helpful information for the FEM forum
Re: Principal Stress Plots
Re: Principal Stress Plots
OK, but now I am confused. Just please make a PR ready to be merged.
In the current PR i only see a removal.
So again, why does it harm to have the stresses there? We are few hours before a release and I don't have time to dive in that deep. If the stresses don't harm there, I would keep them.
Re: Principal Stress Plots
It should be fine like this. The fact that they were first declared a vector and after that a scalar meant that it didn’t work. As long as they are declared a vector and the scalar part is removed we are good to go.
Re: Principal Stress Plots
I'm still almost 100% sure that the current PR is correct. What I meant in the previous reply is that I only removed the 3 lines with resFCScalProp because I didn't have to redefine them as vectors above - their equivalents with resFCVecProp were already there in the original file. Notepad shows me all the differences, it would find any other changes that I missed.
And HarryvL confirmed that it was supposed to be done this way.
Last edited by NewJoker on Mon Jun 13, 2022 4:22 pm, edited 1 time in total.
Re: Principal Stress Plots
They were declared twice. That doesn’t work. Now it is fine.uwestoehr wrote: ↑Mon Jun 13, 2022 4:07 pmOK, but now I am confused. Just please make a PR ready to be merged.
In the current PR i only see a removal.
So again, why does it harm to have the stresses there? We are few hours before a release and I don't have time to dive in that deep. If the stresses don't harm there, I would keep them.
Re: Principal Stress Plots
OK, I merged the 2 PRs. Please checkout if the issue is now fixed for you in master.
Re: [fixed] Principal Stress Plots
Thanks, I will
Re: Principal Stress Plots
Sh..t! I broke master by merging it. Can you please send me a fix for the failing test:
https://gitlab.com/freecad/FreeCAD-CI/-/jobs/2584056477