[merged] PR #5357 - add feature to create tapered Pads / Pockets
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
[merged] PR #5357 - add feature to create tapered Pads / Pockets
This PR adds a requested feature to create tapered Pads / Pockets:
https://github.com/FreeCAD/FreeCAD/pull/5357
Other CAD programs provide this and also our Pad Extrude feature has this. The PR therefore takes basically the Part Extrude code.
Here are screencasts of the feature in action:
For developers: The method of building the Pad / Pocket with the angle is universal. There is a comment in the code that one should better not use BRepFeat_MakePrism for Pads. With my PR I could get rid of BRepFeat_MakePrism since I can set the angle to zero and build a tapered pad also with the implemented BRepOffsetAPI_ThruSections method. Is this would be advantageous I can make a PR accordingly after this PR is merged.
https://github.com/FreeCAD/FreeCAD/pull/5357
Other CAD programs provide this and also our Pad Extrude feature has this. The PR therefore takes basically the Part Extrude code.
Here are screencasts of the feature in action:
For developers: The method of building the Pad / Pocket with the angle is universal. There is a comment in the code that one should better not use BRepFeat_MakePrism for Pads. With my PR I could get rid of BRepFeat_MakePrism since I can set the angle to zero and build a tapered pad also with the implemented BRepOffsetAPI_ThruSections method. Is this would be advantageous I can make a PR accordingly after this PR is merged.
Re: PR #5357 - add feature to create tapered Pads / Pockets
Great addition, thanks!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Re: PR #5357 - add feature to create tapered Pads / Pockets
Cool feature. Great for castings where draft angles are needed,
Re: PR #5357 - add feature to create tapered Pads / Pockets
Thanks for the new feature! Any idea when it'll be merged?
Speaking of the Part workbench Extrude operation (I know of no Pad Extrude as mentioned in the OP... )
What does the second entry in the "Taper outward angle" do? I made each of these extrudes with a different value in the second field and see no difference.
Speaking of the Part workbench Extrude operation (I know of no Pad Extrude as mentioned in the OP... )
What does the second entry in the "Taper outward angle" do? I made each of these extrudes with a different value in the second field and see no difference.
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Re: PR #5357 - add feature to create tapered Pads / Pockets
These are the taper angles for both directions: You did not set a length for the second direction, therefore you did not see anything.
I am already working on the dialog since it is not intuitive, lacks labels and tooltips. but this thread is about the PartDesign PR.
Re: PR #5357 - add feature to create tapered Pads / Pockets
Please consider sharing the same docs for property description and corresponding tooltips. I've made a first step with PR 5321 for PartDesign but put further work on hold as I've seen you're currently working on the same files; e.g. with for this PR here (which is very welcome!).
Indeed. Sorry for hijacking.
Re: PR #5357 - add feature to create tapered Pads / Pockets
Nice. Every work for the Part WB is welcome because its dialogs need work. Its tooltips (and the ones of the underlying parameter description) need a revision.
Looking forward for you PRs
--------------
And now please only concerning this PR. For all other issues, please open new threads.
-
- Veteran
- Posts: 5513
- Joined: Thu Apr 05, 2018 1:53 am
Re: PR #5357 - add feature to create tapered Pads / Pockets
Did you try with sketches with nested wires? The Part::Extrude tool fails to taper with such sketches. For example, this sketch:
Produces this extrude (failing to cut the inner material).
Produces this extrude (failing to cut the inner material).
Re: PR #5357 - add feature to create tapered Pads / Pockets
I just tried and it does not work: As soon as I set the taper angle to something != 0, only the outer-most wire is considered, the inner ones are ignored -- same as with Part's extrude.
Code: Select all
OS: macOS Mojave (10.14)
Word size of FreeCAD: 64-bit
Version: 0.20.27004 (Git)
Build type: Release
Branch: donovaly-PD-tapered-PadPocket
Hash: 3413c5e921151d41fbadad7eee4623295c374f59
Python version: 3.9.8
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.5.0
Locale: English/United States (en_US)
Re: PR #5357 - add feature to create tapered Pads / Pockets
This is on purpose because I took purposely the Part Extrude code. If there is a taper angle, it only takes the outer wire of the sketch to extrude.TheMarkster wrote: ↑Sun Jan 09, 2022 12:15 am Did you try with sketches with nested wires? The Part::Extrude tool fails to taper with such sketches.
One could also take the inner wires as PartDesign Loft does so there must be a reason. And when thinking on how to implement the tapered option for inner wires I can imagine why these are not handled:
- for example if you have a circular hole in your sketch, you probably don't want to have it a taper angle, only for the outer sketch wire
- if you have an inner wire, you might want to have a different taper angle. For example when molding plastics the shrinkage is volume-dependent and then the inner taper angles might indeed have different values
So I don't want to reinvent the wheel. Part's Extrude feature is there for ages and obviously people can live that inner wires are not extruded when there is a taper angle.