[merged] PR #5357 - add feature to create tapered Pads / Pockets

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
User avatar
uwestoehr
Veteran
Posts: 4248
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: PR #5357 - add feature to create tapered Pads / Pockets

Post by uwestoehr »

The PR was merged.

@davidosterberg, by changing the code in https://github.com/FreeCAD/FreeCAD/blob ... Helper.cpp you can try out your solution. It will affect Part and PartDesign.
adrianinsaval
Veteran
Posts: 3054
Joined: Thu Apr 05, 2018 5:15 pm

Re: PR #5357 - add feature to create tapered Pads / Pockets

Post by adrianinsaval »

uwestoehr wrote:
Hello uwe, please look at this example, the same sketch (copy pasted) can be extruded with taper without issues in Part but not in Part Design, even without taper, I think the sketch validation is still usign whatever rules applied to the old pad algorithm but your new algorithm can actually handle this kind of nested shapes.

Oh and let's not forget that the error message is absolutely useless:

Code: Select all

14:38:05  Recompute failed! Please check report view.
When you attempt to create the pad from the sketch you receive a more useful message:
Failed to validate broken face
in a popup but once the pad is already created and you change the sketch to have a shape like this you only get that shitty message in report view, nothing about the face.
Attachments
extrudeExample.zip.fcstd
(82.53 KiB) Downloaded 18 times
User avatar
Shalmeneser
Veteran
Posts: 4661
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: [merged] PR #5357 - add feature to create tapered Pads / Pockets

Post by Shalmeneser »

In PartDesign, you cannot draw a line inside a line inside a line.
Post Reply