Sort edges before splitting at selected vertex #4136

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
gauna
Posts: 48
Joined: Fri Dec 04, 2015 8:20 pm

Sort edges before splitting at selected vertex #4136

Post by gauna »

Hello,

I generated a pull request issue #4136 fixing issue #4458

The problem is, that edges are not sorted after dividing and therefore two edges may follow after each other which do not have an equal point at all. Inserting an additional sorting line fixes the problem. I also removed the split by "rebaseWire"-Method, as an additional split already exits in the function. It is not clear to me what is the intended behavior if both StartVertex are given and parameter start_idx is given. Now StartVertex has a higher priority if set. Only PathDeburr is using start_idx, which has no StartVertex-feature. So, there should be no problem rising. I tested deburr and engrave. Both are working in a short test.
Post Reply