PR #4082 [TD] Make Dimension label graphical layout more compact

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
aapo
Posts: 615
Joined: Mon Oct 29, 2018 6:41 pm

PR #4082 [TD] Make Dimension label graphical layout more compact

Post by aapo »

Recently, TechDraw Dimension labels have suffered a regression in regards to Dimension tolerance label positioning. The regression appears to be caused either by changes in the Qt library, or the default FreeCAD font. The proposed fix is done by tightening the label bounding rectangles, by using Qt's QFontMetrics tightBoundingRect() to calculate a more reasonable bounding box for the labels. Further discussion in this thread: https://forum.freecadweb.org/viewtopic.php?f=35&t=52621


https://github.com/FreeCAD/FreeCAD/pull/4082
Post Reply