[retracted] PR 3737 - don't show by default report view for warnings

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
vocx
Veteran
Posts: 5197
Joined: Thu Oct 18, 2018 9:18 pm

Re: PR 3737 - don't show by default report view for warnings

Post by vocx »

uwestoehr wrote: Sun Jul 26, 2020 12:06 pm ...
For her the file works, so why is she by default forced to see detail stuff not necessary for her real task (in this case to print the part as soon as possible)?
I think in this case, the warning message itself is justified, because when "Links go outside the scope" you should be warned.

However, in this case the problem should be solved in the PartDesign Workbench because clearly you aren't doing something wrong in the model. So, it's a combination of two things, the warning is thrown unnecessarily, and second, the warning makes the report window open, which should probably not occur.
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: PR 3737 - don't show by default report view for warnings

Post by uwestoehr »

vocx wrote: Sun Jul 26, 2020 10:11 pm and second, the warning makes the report window open, which should probably not occur.
Yes, and this is all my PR does.

The other issue needs to be addressed separately.
TheMarkster
Veteran
Posts: 5505
Joined: Thu Apr 05, 2018 1:53 am

Re: PR 3737 - don't show by default report view for warnings

Post by TheMarkster »

IMO, the default should be set to true specifically to benefit new users. Those who are annoyed can disable the preference.
TheMarkster
Veteran
Posts: 5505
Joined: Thu Apr 05, 2018 1:53 am

Re: PR 3737 - don't show by default report view for warnings

Post by TheMarkster »

Related PR: https://github.com/FreeCAD/FreeCAD/pull/3754

This adds the preferences to the right-click context menu of the report view.
Snip macro screenshot-dbd7ef.png
Snip macro screenshot-dbd7ef.png (31.63 KiB) Viewed 1547 times
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: PR 3737 - don't show by default report view for warnings

Post by wmayer »

IMO, the context-menu looks a bit messy and it's not immediately clear what the difference is between "Logging" and "Show on Logging", etc.
Maybe it's easier to create a sub-menu "Show report view" and move the "Show ..." actions there -- but dropping the two words "Show on"
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: PR 3737 - don't show by default report view for warnings

Post by openBrain »

Agree with @wmayer.
Maybe also the simple "Logging", "Warning", "Error" could be respectively replaced by "Display log messages", "Display warning messages", "Display error messages". These 3 could also be grouped in a submenu.

Also the "Show on" could be clearer being "Expand on" (but hey, I'm not native english speaker :D)
TheMarkster
Veteran
Posts: 5505
Joined: Thu Apr 05, 2018 1:53 am

Re: PR 3737 - don't show by default report view for warnings

Post by TheMarkster »

Snip macro screenshot-1fc615.png
Snip macro screenshot-1fc615.png (28.09 KiB) Viewed 1491 times
Snip macro screenshot-3c2246.png
Snip macro screenshot-3c2246.png (26.46 KiB) Viewed 1491 times
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: PR 3737 - don't show by default report view for warnings

Post by openBrain »

TheMarkster wrote: Wed Jul 29, 2020 2:26 am
:+1:
Post Reply