PR#2862: Configuration Table using Spreadsheet

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
chennes
Veteran
Posts: 3878
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: PR#2862: Configuration Table using Spreadsheet

Post by chennes »

For those following along at home, we've just merged a big chunk of this PR in, as of git commit afd003db78c4bac028a5300055caa833778d248d. Thanks again to @realthunder for the excellent work, and to everyone who helped with the testing process. There still remains one chunk of code before we're fully integrated, but the new copy and paste interface, and cell binding, are now in the main development trunk.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: PR#2862: Configuration Table using Spreadsheet

Post by carlopav »

Wow, Great!
follow my experiments on BIM modelling for architecture design
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: PR#2862: Configuration Table using Spreadsheet

Post by carlopav »

chennes wrote: Wed Dec 22, 2021 4:47 am For those following along at home, we've just merged a big chunk of this PR in, as of git commit afd003db78c4bac028a5300055caa833778d248d. Thanks again to @realthunder for the excellent work, and to everyone who helped with the testing process. There still remains one chunk of code before we're fully integrated, but the new copy and paste interface, and cell binding, are now in the main development trunk.
I gave it a quick test compiling from source, mainly to test the href/HIDDENREF expression and the mutated PartDesign::SubShapeBinder. It doesn't seem to be yet available, is it?

Also I noticed I cannot display the transform gizmo on a PartDesign::SubShapeBinder object.
follow my experiments on BIM modelling for architecture design
kaih
Posts: 123
Joined: Tue Dec 31, 2019 12:45 pm

Re: PR#2862: Configuration Table using Spreadsheet

Post by kaih »

Hello together, i have a strange behavior with spreadsheets in FreeCAD 0.20 and chrisb pointed me to here. Maybe it is connected to this changes.

The behaviour is like following. I have a file with two spreadsheets. One is for data entry and the second for calculatios. The values of the second spreadsheet is being used at the 3D model then. I used much aliases for the cell as it is more convenient to use them instead of using cell position like A2, A3,B1,... once i reopen the file and do changes of the values in the first spreadsheet then cells in spreadsheet two will not get calculated again. I did some research about it. It seems aliases of cells are the reason why it's not working.

I created a small test file to show the problem (attached to this post). Spreadsheet "Eingabe" is for entry of data, "Ausgabe" is for the calculations. First row of second spreadsheet the cell position is directly used, second row cell alias is being used, third spreadsheet label is being used.
You will see that changes in spreadsheet "Eingabe" will result in changes in row 1 and 3 of spreadsheet "Ausgabe" but not in row two. Just if you do changes in formula/expression of row two, then recalculation will work again. But next time you open the file again, recalculations don't work again.

I don't have similar problems in FreeCAD 0.19

here the link to my original post in German section of board: https://forum.freecadweb.org/viewtopic.php?f=13&t=65590

my FreeCAD Version with problem
OS: Manjaro Linux (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.27078 (Git) AppImage
Build type: Release
Branch: (HEAD detached at bcdd926)
Hash: bcdd926686f2245fe60baface1cce1ab3dff7a5b
Python version: 3.9.9
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.3
Locale: German/Germany (de_DE)
FreeCAD without problem:
OS: Manjaro Linux (KDE/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24291 (Git)
Build type: Release
Branch: makepkg
Hash: 7b5e18a0759de778b74d3a5c17eba9cb815035ac
Python version: 3.10.1
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.3
Locale: German/Germany (de_DE)
Attachments
test2.FCStd
(2.03 KiB) Downloaded 99 times
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: PR#2862: Configuration Table using Spreadsheet

Post by realthunder »

kaih wrote: Sun Jan 23, 2022 8:48 pm Hello together, i have a strange behavior with spreadsheets in FreeCAD 0.20 and chrisb pointed me to here. Maybe it is connected to this changes.
Thanks for reporting. PR submitted here.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
user1234
Veteran
Posts: 3335
Joined: Mon Jul 11, 2016 5:08 pm

Re: PR#2862: Configuration Table using Spreadsheet

Post by user1234 »

realthunder wrote: Mon Jan 24, 2022 1:41 am Thanks for reporting. PR submitted here.
chennes has merged the PR in the master. Works here, many thanks for the fast fix!

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.20.27194 (Git)
Build type: Release
Branch: master
Hash: 1e4da60367a7aa52793c3cc5ee567dcc9bce91ac
Python version: 3.9.2
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.6.0
Locale: English/United States (en_US)

Greetings
user1234
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: PR#2862: Configuration Table using Spreadsheet

Post by wmayer »

Here the mandatory unit test: git commit 10ca067d95
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: PR#2862: Configuration Table using Spreadsheet

Post by carlopav »

After some test with @paullee as reported in this topic: https://forum.freecadweb.org/viewtopic. ... 01#p568801
it looks like FC master is now able to read an href() function that was created with RT's Fork, but if you want to create that peculiar expression in FC master you are not able to (looks like it is not recognized by the expression completer).

Any hint?


EDIT: My fault, the href() expression works flawlessly.
follow my experiments on BIM modelling for architecture design
zohozer
Posts: 119
Joined: Mon Jul 28, 2014 8:35 pm

Re: PR#2862: Configuration Table using Spreadsheet

Post by zohozer »

It is possible to add If, ELSE conditionals?

In Inventor you can use this kind of logic to enable disable features If...Then...Else Statement

In Solidworks: The Syntax of a SOLIDWORKS “IF” Statement in an Equation

The posibilities are endless. You can enable/disable features in Sketches using the IF/ELSE logic. For example you can define that IF the part is 200mm in Length, to have 3 holes, IF 300mm to have 45 holes, etc.
Post Reply