PR 2820, Draft polar array fix

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
Gift
Posts: 769
Joined: Tue Aug 18, 2015 10:08 am
Location: Germany, Sauerland

PR 2820, Draft polar array fix

Post by Gift »

PR #2820

Hello everybody,

Since the commit of Draft_LinkArray the DraftArray do not produce the same result with polar type as usual. This is a breach to fork 18.4. The initiator is this German discussion.

My solution is to separate the object vector and the object rotation of the placement. Then rotate the vectors with the array parameter and after that the rotation of the object stated earlier by multiply. I think a simpler method must exist.

Feel you free to share your views.

best wishes
Benjamin
C_h_o_p_i_n
Posts: 225
Joined: Fri Apr 26, 2019 3:14 pm

Re: PR 2820, Draft polar array fix

Post by C_h_o_p_i_n »

Hi,

might this be important for the Path-Array Function too ???

regards,
Stefan
chrisb
Veteran
Posts: 54201
Joined: Tue Mar 17, 2015 9:14 am

Re: PR 2820, Draft polar array fix

Post by chrisb »

Gift wrote: Tue Dec 24, 2019 1:26 pm This is a breach to fork 18.4.
There was an intermediate state where things did no longer as they worked before. This was discussed and corrected in the german forum discussion. The faulty state may have made it into 18.4.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Post Reply