Bug: LeadInOut dressup created on Cancel

[Russ4262]

Evening,
I was working on another related issue and discovered that the LeadInOut Dressup creates the dressup upon activation even when the Cancel button is pressed in its task panel.

Steps to reproduce:

1. Open a model file, and open Path workbench.
2. Select the model, and create a Job object with defaults accepted.
3. Create Profile object with defaults accepted, no feature selection (Base Geometry).
4. Right-click on Profile in object tree and select LeadInOut Dressup. (Or, select Profile in object tree and select the dressup from the Path menu.)
5. Click the Cancel button in the LeadInOut task panel.
6. The dressup is still created and added to the object tree as if OK was pressed.

Can anyone confirm? Sample model file attached.

Thanks,
Russell

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.28793 (Git)
Build type: Release
Branch: master
Hash: 72e91dbbca9094d9bd56b1d47a1eeaaeb7266849
Python 3.8.6+, Qt 5.15.2, Coin 4.0.1, OCC 7.5.0
Locale: English/United States (en_US)
Installed mods: 
  * FC_SU
  * Z_MacroStartup

[jescombe]

Can anyone confirm? Sample model file attached.

Yes, can confirm I see the same behaviour (28671 appimage)..

Regards,
Jon

[Russ4262]

Afternoon,
With LuzPaz request, Path: Fixes #6849 - Properly cancel new Lead In/Out dressup is now active as a possible solution.

Russell

Edit: PR closed 14 July