I have just pushed the next round of updates and changes to the PR. The large change is based on a comment that @Sliptonic
mentioned to me a few weeks back about developing in parallel to current capability and structure. I have implemented many of the big changes I have been working on in a separate dev branch into this PR by creating a new experimental Clearing operation.
The change I just pushed today creates a new experimental Clearing operation that combines current PocketShape, MillFace, 3D Pocket, and Adaptive operations. All four of these existing ops do the same thing: clear material from a 3D envelope. Now instead of four separate operations, users will be able to use a single Clearing op, if they have Experimental Features enabled. The new cut pattern fixes in this PR are now implemented in this new Clearing op, rather than the current PocketShape, MillFace, and 3D Pocket ops as originally presented. This change has the added benefit of leaving current ops alone so as to not introduce new bugs.
Sorry for my miscommunication earlier. When I stated, "I believe this is already taken care of," I was referring to this new PR, not existing Path capabilities. My testing does show layer fidelity to current "StartAt" (named `CutPatternReversed` in new Clearing op) feature in this PR. Since existing ops are unchanged now (except for very minor fixes as found), this alternating start location will still exist in the PocketShape, MillFace, and 3D Pocket ops, but fixed in the new Clearing op that makes use of the new path generation class.GeneFC wrote: ↑Thu Aug 19, 2021 1:29 pm... The problem with either the Edge/Center or Start At is that the selection is not honored after the first layer.
... I just ran a very simple pocket test, with "Start at Center" set, and "Min Travel False". The alternating inside/outside behavior for successive depth layers is still present. ...
As for the KeepToolDown feature, I have made some progress on some of the patterns in the new Clearing op proposed. Looking at the Offset pattern, I need to fix a bug related to this KeepToolDown feature as of this post. Some of the rapids are cutting through raised portions of the model. I will look at this when I get some more time.
I have not touched the `MinTravel` feature as it relates to this PR and the new cut pattern generation class. If the `MinTravel` simply alternates layer start points depending on where previous layer ends and current layer begins, such an algorithm could be added and the paths adjusted accordingly. For now, I am not working on this feature.
Because of the major changes to this PR (the implementation of the new Clearing op to showcase the new cut pattern fixes), I updated the cut pattern test macro file in the OP. That model file posted in the OP is still the valid base file for the test macro.
I have attached screenshots from the new Clearing op. The op combines the current Heights and Depths task panels. It includes the Extensions feature. It organizes the properties in the Operations tab and includes settings for Adaptive clearing only when needed. There is a new `Visualize` button to visualize the target removal shape based on Base Geometry, Extensions, and settings in the `Selection Options` portion of the Operations tab.
Fun and exciting stuff happening! Thanks a million those offering feedback and conducting testing of this PR.
This PR is still in Draft phase.
Have a great week.
Russell